From: Jason Molenda <jason-swarelist@molenda.com>
To: Andreas Schwab <schwab@suse.de>
Cc: gdb-patches@sources.redhat.com
Subject: Re: The gdb x86 function prologue parser
Date: Thu, 09 Jun 2005 06:26:00 -0000 [thread overview]
Message-ID: <20050608232556.A53178@molenda.com> (raw)
In-Reply-To: <jeacm0d3jf.fsf@sykes.suse.de>; from schwab@suse.de on Wed, Jun 08, 2005 at 09:58:12PM +0200
Hi Andreas,
On Wed, Jun 08, 2005 at 09:58:12PM +0200, Andreas Schwab wrote:
> >> +#include <stdint.h>
>
> Since this is a target (not native) file it needs to use types portable to
> all hosts.
I'll drop stdint.h because it requires ISO C99, but I don't understand
your comment. Is there some environment where uint32_t isn't 4 bytes?
This is how I was using uint32_t and uint8_t:
+ /* 81 /5 id SUB r/m32, imm32 */
+ if (op == 0x81 && next_op == 0xec)
+ {
+ uint32_t imm32 = read_memory_integer (pc + 2, 4);
+ esp_change -= imm32;
+ pc += 6;
+ continue;
+ }
If code like this is wrong, I'd like to know.
Thanks,
Jason
next prev parent reply other threads:[~2005-06-09 6:26 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-06-08 5:51 Jason Molenda
2005-06-08 13:24 ` Daniel Jacobowitz
2005-06-08 16:58 ` Jason Molenda
2005-06-12 7:48 ` Mark Kettenis
2005-06-12 8:44 ` Eli Zaretskii
[not found] ` <3364FC4D-63FB-493B-9136-D118F74C13BB@mit.edu>
2005-06-12 13:17 ` Eli Zaretskii
2005-06-12 14:28 ` Daniel Jacobowitz
2005-06-13 18:21 ` Michael Snyder
2005-06-13 19:13 ` Eli Zaretskii
2005-06-08 14:52 ` Eli Zaretskii
2005-06-08 17:01 ` Jason Molenda
2005-06-08 18:03 ` Eli Zaretskii
2005-06-08 19:58 ` Andreas Schwab
2005-06-09 6:26 ` Jason Molenda [this message]
2005-06-09 9:02 ` Andreas Schwab
2005-06-10 20:23 ` Michael Snyder
2005-06-12 7:57 ` Mark Kettenis
2005-06-10 20:29 ` Michael Snyder
2005-06-10 21:18 ` Eli Zaretskii
2005-06-12 7:07 ` Mark Kettenis
2005-06-12 8:50 ` Eli Zaretskii
2005-06-13 22:04 ` Jason Molenda
2005-06-13 22:35 ` Mark Kettenis
2005-06-13 22:51 ` Daniel Jacobowitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050608232556.A53178@molenda.com \
--to=jason-swarelist@molenda.com \
--cc=gdb-patches@sources.redhat.com \
--cc=schwab@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox