From: Hans-Peter Nilsson <hans-peter.nilsson@axis.com>
To: drow@false.org
Cc: gdb-patches@sourceware.org
Subject: Re: cp-name-parser.y
Date: Sat, 28 May 2005 18:28:00 -0000 [thread overview]
Message-ID: <200505281752.j4SHqllp024779@ignucius.se.axis.com> (raw)
In-Reply-To: <20050528164959.GB26806@nevyn.them.org> (message from Daniel Jacobowitz on Sat, 28 May 2005 12:49:59 -0400)
> Date: Sat, 28 May 2005 12:49:59 -0400
> From: Daniel Jacobowitz <drow@false.org>
> On Sat, May 28, 2005 at 10:22:27AM -0400, Daniel Jacobowitz wrote:
> > On Sat, May 28, 2005 at 10:58:31AM +0200, Hans-Peter Nilsson wrote:
> > > It takes two looks.
> >
> > Maybe it takes three?
Probably; I incorrectly assumed that the code that person wrote
was correct to the main parts and didn't review it's semantics.
I hope to avoid that in the future. :-)
> Your patch is incorrect, since it is covering up
> > a real problem. It ought to be "return c".
>
> Like so. Checked with GCC 4.1.0 20050508 and committed.
Thanks.
brgds, H-P
prev parent reply other threads:[~2005-05-28 17:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-28 16:44 Committed, MAINTAINERS, sim/cris: Fix make -j race and mark cris-elf as non-broken, cp-name-parser.y Hans-Peter Nilsson
2005-05-28 16:50 ` Daniel Jacobowitz
2005-05-28 18:07 ` Daniel Jacobowitz
2005-05-28 18:28 ` Hans-Peter Nilsson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200505281752.j4SHqllp024779@ignucius.se.axis.com \
--to=hans-peter.nilsson@axis.com \
--cc=drow@false.org \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox