From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13491 invoked by alias); 28 May 2005 17:54:19 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 13143 invoked by uid 22791); 28 May 2005 17:54:10 -0000 Received: from nic2.axis.se (HELO krynn.se.axis.com) (193.13.178.10) by sourceware.org (qpsmtpd/0.30-dev) with ESMTP; Sat, 28 May 2005 17:54:10 +0000 Received: from ignucius.se.axis.com (ignucius.se.axis.com [10.83.5.18]) by krynn.se.axis.com (8.12.9/8.12.9/Debian-5local0.1) with ESMTP id j4SHqoF2024395; Sat, 28 May 2005 19:52:50 +0200 Received: from ignucius.se.axis.com (localhost [127.0.0.1]) by ignucius.se.axis.com (8.12.8p1/8.12.8/Debian-2woody1) with ESMTP id j4SHqodi024783; Sat, 28 May 2005 19:52:50 +0200 Received: (from hp@localhost) by ignucius.se.axis.com (8.12.8p1/8.12.8/Debian-2woody1) id j4SHqllp024779; Sat, 28 May 2005 19:52:47 +0200 Date: Sat, 28 May 2005 18:28:00 -0000 Message-Id: <200505281752.j4SHqllp024779@ignucius.se.axis.com> From: Hans-Peter Nilsson To: drow@false.org CC: gdb-patches@sourceware.org In-reply-to: <20050528164959.GB26806@nevyn.them.org> (message from Daniel Jacobowitz on Sat, 28 May 2005 12:49:59 -0400) Subject: Re: cp-name-parser.y X-SW-Source: 2005-05/txt/msg00582.txt.bz2 > Date: Sat, 28 May 2005 12:49:59 -0400 > From: Daniel Jacobowitz > On Sat, May 28, 2005 at 10:22:27AM -0400, Daniel Jacobowitz wrote: > > On Sat, May 28, 2005 at 10:58:31AM +0200, Hans-Peter Nilsson wrote: > > > It takes two looks. > > > > Maybe it takes three? Probably; I incorrectly assumed that the code that person wrote was correct to the main parts and didn't review it's semantics. I hope to avoid that in the future. :-) > Your patch is incorrect, since it is covering up > > a real problem. It ought to be "return c". > > Like so. Checked with GCC 4.1.0 20050508 and committed. Thanks. brgds, H-P