* [RFA] sim/common/Make-common.in: Correct dependency for LIBDEPS
@ 2005-05-24 14:22 Corinna Vinschen
2005-05-24 15:29 ` Daniel Jacobowitz
0 siblings, 1 reply; 3+ messages in thread
From: Corinna Vinschen @ 2005-05-24 14:22 UTC (permalink / raw)
To: gdb-patches
Hi,
LIBDEPS in sim/common/Make-common.in defines the dependencies used
to figure out what has to be build, while EXTRA_LIBS defines what
libraries are used for building.
The same difference is made for INTLDEPS vs. INTLLIBS. Nevertheless,
LIBDEPS depends on $(INTLLIBS) instead of $(INTLDEPS), which would
be the correct dependency.
The below patch fixes that. Ok to apply?
Corinna
* Make-common.in (LIBDEPS): Correctly use INTLDEPS for dependency
check.
Index: sim/common/Make-common.in
===================================================================
RCS file: /cvs/src/src/sim/common/Make-common.in,v
retrieving revision 1.23
diff -u -p -r1.23 Make-common.in
--- sim/common/Make-common.in 18 May 2005 01:55:46 -0000 1.23
+++ sim/common/Make-common.in 24 May 2005 14:07:57 -0000
@@ -241,7 +241,7 @@ OPCODES_LIB = ../../opcodes/libopcodes.a
INTLLIBS = @INTLLIBS@
INTLDEPS = @INTLDEPS@
CONFIG_LIBS = @LIBS@
-LIBDEPS = $(BFD_LIB) $(OPCODES_LIB) $(INTLLIBS) $(LIBIBERTY_LIB) \
+LIBDEPS = $(BFD_LIB) $(OPCODES_LIB) $(INTLDEPS) $(LIBIBERTY_LIB) \
$(SIM_EXTRA_LIBDEPS)
EXTRA_LIBS = $(BFD_LIB) $(OPCODES_LIB) $(INTLLIBS) $(LIBIBERTY_LIB) \
$(CONFIG_LIBS) $(SIM_EXTRA_LIBS)
--
Corinna Vinschen
Cygwin Project Co-Leader
Red Hat, Inc.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [RFA] sim/common/Make-common.in: Correct dependency for LIBDEPS
2005-05-24 14:22 [RFA] sim/common/Make-common.in: Correct dependency for LIBDEPS Corinna Vinschen
@ 2005-05-24 15:29 ` Daniel Jacobowitz
2005-05-24 15:43 ` Corinna Vinschen
0 siblings, 1 reply; 3+ messages in thread
From: Daniel Jacobowitz @ 2005-05-24 15:29 UTC (permalink / raw)
To: gdb-patches
On Tue, May 24, 2005 at 04:08:27PM +0200, Corinna Vinschen wrote:
> Hi,
>
> LIBDEPS in sim/common/Make-common.in defines the dependencies used
> to figure out what has to be build, while EXTRA_LIBS defines what
> libraries are used for building.
>
> The same difference is made for INTLDEPS vs. INTLLIBS. Nevertheless,
> LIBDEPS depends on $(INTLLIBS) instead of $(INTLDEPS), which would
> be the correct dependency.
>
> The below patch fixes that. Ok to apply?
>
>
> Corinna
>
> * Make-common.in (LIBDEPS): Correctly use INTLDEPS for dependency
> check.
Yes, this is OK. Nice catch.
--
Daniel Jacobowitz
CodeSourcery, LLC
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [RFA] sim/common/Make-common.in: Correct dependency for LIBDEPS
2005-05-24 15:29 ` Daniel Jacobowitz
@ 2005-05-24 15:43 ` Corinna Vinschen
0 siblings, 0 replies; 3+ messages in thread
From: Corinna Vinschen @ 2005-05-24 15:43 UTC (permalink / raw)
To: gdb-patches
On May 24 10:11, Daniel Jacobowitz wrote:
> On Tue, May 24, 2005 at 04:08:27PM +0200, Corinna Vinschen wrote:
> > * Make-common.in (LIBDEPS): Correctly use INTLDEPS for dependency
> > check.
>
> Yes, this is OK. Nice catch.
Thanks, applied. (Approved within three minutes! New record? :-))
Corinna
--
Corinna Vinschen
Cygwin Project Co-Leader
Red Hat, Inc.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2005-05-24 14:22 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2005-05-24 14:22 [RFA] sim/common/Make-common.in: Correct dependency for LIBDEPS Corinna Vinschen
2005-05-24 15:29 ` Daniel Jacobowitz
2005-05-24 15:43 ` Corinna Vinschen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox