From: Daniel Jacobowitz <drow@false.org>
To: Joel Brobecker <brobecker@adacore.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [RFA/alpha] Add handling of FP control insn in software-single step (second try)
Date: Fri, 20 May 2005 06:18:00 -0000 [thread overview]
Message-ID: <20050520033500.GA12297@nevyn.them.org> (raw)
In-Reply-To: <20050520012055.GY1462@adacore.com>
On Fri, May 20, 2005 at 11:20:55AM +1000, Joel Brobecker wrote:
> This is a rework of:
>
> http://sources.redhat.com/ml/gdb-patches/2005-05/msg00405.html
>
> Hopefully this patch will be more acceptable.
>
> 2005-05-17 Joel Brobecker <brobecker@adacore.com>
>
> * alpha-tdep.c (fp_register_zero_p): New function.
> (fp_register_sign_bit): New function.
> (alpha_next_pc): Add support for floating-point control instructions.
>
> Tested on alpha-tru64 5.1a with no regression. I'll try to contribute
> an asm test asap.
>
> One remark: For zero_mask in fp_register_zero_p(), Richard suggested
> to use "((LONGEST) 1 << 63) - 1", but that triggered an overflow warning
> from GCC. So I reverted to using the xor binary operator. Daniel said
> that many things would break in GDB with 128-bit types, so I think the
> xor is quite acceptable for now.
>
> OK to commit?
I was just waiting for Richard to OK the actual implementation. This
is fine, thank you.
--
Daniel Jacobowitz
CodeSourcery, LLC
next prev parent reply other threads:[~2005-05-20 3:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-20 2:34 Joel Brobecker
2005-05-20 3:35 ` Richard Henderson
2005-05-20 6:18 ` Daniel Jacobowitz [this message]
2005-05-20 12:11 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050520033500.GA12297@nevyn.them.org \
--to=drow@false.org \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox