From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23386 invoked by alias); 20 May 2005 03:35:11 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 23353 invoked from network); 20 May 2005 03:35:05 -0000 Received: from unknown (HELO nevyn.them.org) (66.93.172.17) by sourceware.org with SMTP; 20 May 2005 03:35:05 -0000 Received: from drow by nevyn.them.org with local (Exim 4.50) id 1DYyHs-0003Cl-Tc; Thu, 19 May 2005 23:35:01 -0400 Date: Fri, 20 May 2005 06:18:00 -0000 From: Daniel Jacobowitz To: Joel Brobecker Cc: gdb-patches@sources.redhat.com Subject: Re: [RFA/alpha] Add handling of FP control insn in software-single step (second try) Message-ID: <20050520033500.GA12297@nevyn.them.org> Mail-Followup-To: Joel Brobecker , gdb-patches@sources.redhat.com References: <20050520012055.GY1462@adacore.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20050520012055.GY1462@adacore.com> User-Agent: Mutt/1.5.8i X-SW-Source: 2005-05/txt/msg00484.txt.bz2 On Fri, May 20, 2005 at 11:20:55AM +1000, Joel Brobecker wrote: > This is a rework of: > > http://sources.redhat.com/ml/gdb-patches/2005-05/msg00405.html > > Hopefully this patch will be more acceptable. > > 2005-05-17 Joel Brobecker > > * alpha-tdep.c (fp_register_zero_p): New function. > (fp_register_sign_bit): New function. > (alpha_next_pc): Add support for floating-point control instructions. > > Tested on alpha-tru64 5.1a with no regression. I'll try to contribute > an asm test asap. > > One remark: For zero_mask in fp_register_zero_p(), Richard suggested > to use "((LONGEST) 1 << 63) - 1", but that triggered an overflow warning > from GCC. So I reverted to using the xor binary operator. Daniel said > that many things would break in GDB with 128-bit types, so I think the > xor is quite acceptable for now. > > OK to commit? I was just waiting for Richard to OK the actual implementation. This is fine, thank you. -- Daniel Jacobowitz CodeSourcery, LLC