Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Corinna Vinschen <vinschen@redhat.com>
To: gdb-patches@sources.redhat.com
Subject: Re: [RFA] Resurrect v850
Date: Wed, 18 May 2005 10:18:00 -0000	[thread overview]
Message-ID: <20050518085316.GO18174@calimero.vinschen.de> (raw)
In-Reply-To: <20050518011043.GA8672@nevyn.them.org>

On May 17 21:10, Daniel Jacobowitz wrote:
> On Tue, May 17, 2005 at 04:09:35PM +0200, Corinna Vinschen wrote:
> > Ok, I *think* I have followed all your suggestions and hints throughout
> > the file.  The result is attached below.
> 
> This is OK with trivial changes, with or without Mark's suggested
> change for the type of $pc.  Thanks.
> 
> > +/* Info gleaned from scanning a function's prologue.  */
> > +struct pifsr		/* Info about one saved reg */
> > +{
> > +  int offset;		/* Offset from sp or fp */
> > +  int cur_frameoffset;	/* Current frameoffset */
> > +  int reg;		/* Saved register number */
> > +};
> 
> Missed a couple of trailing stops in the comments.
> 
> > +  /* The value is a structure or union with a single element and that
> > +     element is either a single basic type or an array of a single basic
> > +     type whoes size is greater than or equal to 4 -> returned in register.  */
> 
> "whose".

I re-inspected the comments and fixed a few more.  I've also changed
v850_register_type according to Mark's suggestion.

Applied.


Thanks to both of you,
Corinna

-- 
Corinna Vinschen
Cygwin Project Co-Leader
Red Hat, Inc.


  reply	other threads:[~2005-05-18  8:53 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-05-13 12:28 Corinna Vinschen
2005-05-15 18:20 ` Daniel Jacobowitz
2005-05-17 13:39   ` Corinna Vinschen
2005-05-17 13:52     ` Daniel Jacobowitz
2005-05-17 14:39       ` Corinna Vinschen
2005-05-17 20:40         ` Mark Kettenis
2005-05-18  1:11           ` Daniel Jacobowitz
2005-05-18  1:25             ` Mark Kettenis
2005-05-18  1:40         ` Daniel Jacobowitz
2005-05-18 10:18           ` Corinna Vinschen [this message]
2005-05-17 14:01     ` Corinna Vinschen
2005-05-17 14:10       ` Daniel Jacobowitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050518085316.GO18174@calimero.vinschen.de \
    --to=vinschen@redhat.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox