From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26942 invoked by alias); 18 May 2005 08:53:36 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 26775 invoked from network); 18 May 2005 08:53:19 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org with SMTP; 18 May 2005 08:53:19 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.11/8.12.11) with ESMTP id j4I8rIIJ020563 for ; Wed, 18 May 2005 04:53:18 -0400 Received: from potter.sfbay.redhat.com (potter.sfbay.redhat.com [172.16.27.15]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id j4I8rIO30550 for ; Wed, 18 May 2005 04:53:18 -0400 Received: from calimero.vinschen.de (vpn50-33.rdu.redhat.com [172.16.50.33]) by potter.sfbay.redhat.com (8.12.8/8.12.8) with ESMTP id j4I8rGa8028075 for ; Wed, 18 May 2005 04:53:16 -0400 Received: by calimero.vinschen.de (Postfix, from userid 500) id 10F6D6D4203; Wed, 18 May 2005 10:53:16 +0200 (CEST) Date: Wed, 18 May 2005 10:18:00 -0000 From: Corinna Vinschen To: gdb-patches@sources.redhat.com Subject: Re: [RFA] Resurrect v850 Message-ID: <20050518085316.GO18174@calimero.vinschen.de> Reply-To: gdb-patches@sources.redhat.com Mail-Followup-To: gdb-patches@sources.redhat.com References: <20050513114016.GN2805@calimero.vinschen.de> <20050515174426.GA1193@nevyn.them.org> <20050517132348.GF18174@calimero.vinschen.de> <20050517133137.GA3543@nevyn.them.org> <20050517140935.GI18174@calimero.vinschen.de> <20050518011043.GA8672@nevyn.them.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20050518011043.GA8672@nevyn.them.org> User-Agent: Mutt/1.4.2i X-SW-Source: 2005-05/txt/msg00447.txt.bz2 On May 17 21:10, Daniel Jacobowitz wrote: > On Tue, May 17, 2005 at 04:09:35PM +0200, Corinna Vinschen wrote: > > Ok, I *think* I have followed all your suggestions and hints throughout > > the file. The result is attached below. > > This is OK with trivial changes, with or without Mark's suggested > change for the type of $pc. Thanks. > > > +/* Info gleaned from scanning a function's prologue. */ > > +struct pifsr /* Info about one saved reg */ > > +{ > > + int offset; /* Offset from sp or fp */ > > + int cur_frameoffset; /* Current frameoffset */ > > + int reg; /* Saved register number */ > > +}; > > Missed a couple of trailing stops in the comments. > > > + /* The value is a structure or union with a single element and that > > + element is either a single basic type or an array of a single basic > > + type whoes size is greater than or equal to 4 -> returned in register. */ > > "whose". I re-inspected the comments and fixed a few more. I've also changed v850_register_type according to Mark's suggestion. Applied. Thanks to both of you, Corinna -- Corinna Vinschen Cygwin Project Co-Leader Red Hat, Inc.