From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: drow@false.org
Cc: gdb-patches@sources.redhat.com
Subject: Re: [RFC] Unconditionally include shared library code
Date: Sun, 08 May 2005 17:32:00 -0000 [thread overview]
Message-ID: <200505081451.j48EpPTO013691@elgar.sibelius.xs4all.nl> (raw)
In-Reply-To: <20050508144020.GA8650@nevyn.them.org> (message from Daniel Jacobowitz on Sun, 8 May 2005 10:40:20 -0400)
Date: Sun, 8 May 2005 10:40:20 -0400
From: Daniel Jacobowitz <drow@false.org>
> But the problem I'm addressing here is solib.h. It contains both the
> prototypes for the functions in solib.c and the #defines for the hooks
> that make core GDB use those functions. Since the goal of my patch is
> to get away from using those #defines, I can't simply #include solib.h
> in the core GDB source files, unless I do a massive conversion of all
> targets using solib.h. That, I think is rather dangerous. I'd rather
> convert them one-by one, after I've verified that indeed they work
> using the new mechanism.
What bugs me about it is that it's not clear which one is going away.
Would this alternative work for you? Create a new file, solib-macros.h,
and move the macros from solib.h there. Have any targets which
currently include solib.h via their TM_FILE include solib-macros.h
instead, which is a nice mechanical update.
Hmm, that'd work. We'll have to face the inconsistent interface issue
eventually, but it's a seperate issue indeed. Any objection if I
introduce a config/tm-solib.h and use that? Its purpose is a bit more
clear, and the risk of abuse is smaller. The mechanical update is not
without risk, but I'm willing to take it. Deal?
Mark
next prev parent reply other threads:[~2005-05-08 15:33 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-02 12:53 Mark Kettenis
2005-05-08 13:15 ` Mark Kettenis
2005-05-08 13:59 ` Daniel Jacobowitz
2005-05-08 14:24 ` Daniel Jacobowitz
2005-05-08 14:40 ` Mark Kettenis
2005-05-08 14:48 ` Daniel Jacobowitz
2005-05-08 17:32 ` Mark Kettenis [this message]
2005-05-08 15:33 ` Daniel Jacobowitz
2005-05-08 22:01 ` Mark Kettenis
2005-05-08 22:08 ` Daniel Jacobowitz
2005-05-09 20:46 ` Kevin Buettner
2005-05-12 20:40 ` Mark Kettenis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200505081451.j48EpPTO013691@elgar.sibelius.xs4all.nl \
--to=mark.kettenis@xs4all.nl \
--cc=drow@false.org \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox