Re: [PATCH] Add sparc64-linux sigtramp support

["David S. Miller" <davem@davemloft.net>]

On Thu, 21 Apr 2005 21:23:17 +0200 (CEST)
Mark Kettenis <mark.kettenis@xs4all.nl> wrote:

> FYI, "issue" #1 is to make sure the frame base address matches with
> what the DWARF2 unwinder thinks.

Right.

> I'm not thrilled by documenting the "struct pt_regs" layout.  The
> constants already are there in the code.  I think it is more important
> to document where to find the offsets.  I also think it is better to
> point people to "struct sigcontext" instead of "struct pt_regs".
> That's where I got them from.  Can you change the comment in something
> like:
> 
> /* Offsets from <bits/sigcontext.h>.  */
> 
> ?
> 
> Otherwise this is ok, so please go ahead.

Sure, I'll fix this all up.  Thanks for reviewing.  I'd like to convert
this stuff over to the cleaner infrastructure PPC and MIPS linux targets
use, it might mean ditching the solaris tdep sharing though since they
sniff the sigtramps slightly differently.  It's kind of weird that we
let the solaris code register it's sniffer in the chain on linux targets
even though the linux sniffer is registered such that it trumps the solaris
one.

> P.S. I'm close to enabling the DWARF2 unwinder for SPARC, but there
> still are a few issues that I have to solve yet.  None of these affect
> Linux/sparc64.  I can send you a patch to test if you want.

Funny, I started playing around with the DWARF2 unwinder last night
as well on Sparc.  It interacted badly with the signal trampoline
sniffers but otherwise mostly worked, and that's as far as I got before
I went to bed.

Please send me your test patch and what issues you are aware of, I can
likely work on fixing them today/tonight.