From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28942 invoked by alias); 21 Apr 2005 19:29:48 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 28876 invoked from network); 21 Apr 2005 19:29:41 -0000 Received: from unknown (HELO cheetah.davemloft.net) (216.27.180.174) by sourceware.org with SMTP; 21 Apr 2005 19:29:41 -0000 Received: from localhost ([127.0.0.1] helo=cheetah.davemloft.net ident=davem) by cheetah.davemloft.net with smtp (Exim 3.36 #1 (Debian)) id 1DOhGE-0001om-00; Thu, 21 Apr 2005 12:22:50 -0700 Date: Thu, 21 Apr 2005 19:29:00 -0000 From: "David S. Miller" To: Mark Kettenis Cc: gdb-patches@sources.redhat.com Subject: Re: [PATCH] Add sparc64-linux sigtramp support Message-Id: <20050421122250.6108168c.davem@davemloft.net> In-Reply-To: <200504211923.j3LJNHo6010891@elgar.sibelius.xs4all.nl> References: <20050420204427.20d670e6.davem@davemloft.net> <200504211923.j3LJNHo6010891@elgar.sibelius.xs4all.nl> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-SW-Source: 2005-04/txt/msg00258.txt.bz2 On Thu, 21 Apr 2005 21:23:17 +0200 (CEST) Mark Kettenis wrote: > FYI, "issue" #1 is to make sure the frame base address matches with > what the DWARF2 unwinder thinks. Right. > I'm not thrilled by documenting the "struct pt_regs" layout. The > constants already are there in the code. I think it is more important > to document where to find the offsets. I also think it is better to > point people to "struct sigcontext" instead of "struct pt_regs". > That's where I got them from. Can you change the comment in something > like: > > /* Offsets from . */ > > ? > > Otherwise this is ok, so please go ahead. Sure, I'll fix this all up. Thanks for reviewing. I'd like to convert this stuff over to the cleaner infrastructure PPC and MIPS linux targets use, it might mean ditching the solaris tdep sharing though since they sniff the sigtramps slightly differently. It's kind of weird that we let the solaris code register it's sniffer in the chain on linux targets even though the linux sniffer is registered such that it trumps the solaris one. > P.S. I'm close to enabling the DWARF2 unwinder for SPARC, but there > still are a few issues that I have to solve yet. None of these affect > Linux/sparc64. I can send you a patch to test if you want. Funny, I started playing around with the DWARF2 unwinder last night as well on Sparc. It interacted badly with the signal trampoline sniffers but otherwise mostly worked, and that's as far as I got before I went to bed. Please send me your test patch and what issues you are aware of, I can likely work on fixing them today/tonight.