Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <drow@false.org>
To: "M.M. Kettenis" <m.m.kettenis@alumnus.utwente.nl>
Cc: Manoj Iyer <manjo@austin.ibm.com>, gdb-patches@sources.redhat.com
Subject: Re: [RFC] Use HAVE_LONGLONG instead of __GNUC__ to check for long long support.
Date: Tue, 19 Apr 2005 12:33:00 -0000	[thread overview]
Message-ID: <20050419123249.GA22692@nevyn.them.org> (raw)
In-Reply-To: <7320552869539569@webhare>

On Tue, Apr 19, 2005 at 07:58:15AM +0000, M.M. Kettenis wrote:
> Manoj Iyer <manjo@austin.ibm.com> wrote:
> 
> >
> >Daniel,
> >
> >Used autoheader to generate the config.in file, but it does not look
> >pretty, also, removed the comments that you did not like.
> >
> >2005-04-18  Manoj Iyer  <manjo@austin.ibm.com>
> >        * configure.ac: Added check for long long.
> >        * config.in: Regenerated.
> >        * configure: Regenerated.
> >        * words.h: Modified logic to check for HAVE_LONGLONG instead of
> >        __GNUC__, added config.h header file.
> 
> Please use AC_CHECK_TYPES, it should take care of defining
> HAVE_LONG_LONG (note the extra underscore) and the comment all by
> itself.

Wasn't there some problem with AC_CHECK_TYPES?  I remember there used
to be a comment in gdb/configure.in saying to use it, but it was
removed and the manual check is still there.

-- 
Daniel Jacobowitz
CodeSourcery, LLC


  parent reply	other threads:[~2005-04-19 12:33 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-04-18 22:41 Manoj Iyer
2005-04-18 22:52 ` Daniel Jacobowitz
2005-04-18 23:15   ` Manoj Iyer
2005-04-19  7:58     ` M.M. Kettenis
2005-04-19  9:54       ` Manoj Iyer
2005-04-19 10:24         ` [RFC] (Resubmit) " Manoj Iyer
2005-04-19 21:33           ` Manoj Iyer
2005-04-19 21:36             ` Daniel Jacobowitz
2005-04-19 21:48               ` Mark Kettenis
2005-04-19 21:50                 ` Daniel Jacobowitz
2005-04-19 21:43             ` Mark Kettenis
2005-04-19 12:33       ` Daniel Jacobowitz [this message]
2005-04-19 14:56         ` [RFC] " Manoj Iyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050419123249.GA22692@nevyn.them.org \
    --to=drow@false.org \
    --cc=gdb-patches@sources.redhat.com \
    --cc=m.m.kettenis@alumnus.utwente.nl \
    --cc=manjo@austin.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox