From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12667 invoked by alias); 19 Apr 2005 12:33:11 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 12289 invoked from network); 19 Apr 2005 12:32:55 -0000 Received: from unknown (HELO nevyn.them.org) (66.93.172.17) by sourceware.org with SMTP; 19 Apr 2005 12:32:55 -0000 Received: from drow by nevyn.them.org with local (Exim 4.50 #1 (Debian)) id 1DNruL-0005vG-Om; Tue, 19 Apr 2005 08:32:49 -0400 Date: Tue, 19 Apr 2005 12:33:00 -0000 From: Daniel Jacobowitz To: "M.M. Kettenis" Cc: Manoj Iyer , gdb-patches@sources.redhat.com Subject: Re: [RFC] Use HAVE_LONGLONG instead of __GNUC__ to check for long long support. Message-ID: <20050419123249.GA22692@nevyn.them.org> Mail-Followup-To: "M.M. Kettenis" , Manoj Iyer , gdb-patches@sources.redhat.com References: <7320552869539569@webhare> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7320552869539569@webhare> User-Agent: Mutt/1.5.8i X-SW-Source: 2005-04/txt/msg00219.txt.bz2 On Tue, Apr 19, 2005 at 07:58:15AM +0000, M.M. Kettenis wrote: > Manoj Iyer wrote: > > > > >Daniel, > > > >Used autoheader to generate the config.in file, but it does not look > >pretty, also, removed the comments that you did not like. > > > >2005-04-18 Manoj Iyer > > * configure.ac: Added check for long long. > > * config.in: Regenerated. > > * configure: Regenerated. > > * words.h: Modified logic to check for HAVE_LONGLONG instead of > > __GNUC__, added config.h header file. > > Please use AC_CHECK_TYPES, it should take care of defining > HAVE_LONG_LONG (note the extra underscore) and the comment all by > itself. Wasn't there some problem with AC_CHECK_TYPES? I remember there used to be a comment in gdb/configure.in saying to use it, but it was removed and the manual check is still there. -- Daniel Jacobowitz CodeSourcery, LLC