Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <drow@false.org>
To: Kei Sakamoto <sakamoto.kei@renesas.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [RFC/m32r] Add gdbserver support to m32r-linux
Date: Thu, 14 Apr 2005 19:18:00 -0000	[thread overview]
Message-ID: <20050414191846.GG26377@nevyn.them.org> (raw)
In-Reply-To: <013d01c53fff$6cc753e0$5169910a@E5A02646>

On Wed, Apr 13, 2005 at 05:04:32PM +0900, Kei Sakamoto wrote:
> Thank you for reviewing my patch!
> I revised my patch as the following.
> 
> 
> > > +linux-m32r-low.o: linux-m32r-low.c $(linux_low_h) $(server_h) ../m32r-tdep.h
> > 
> > This doesn't seem to be necessary.
> 
> I removed the above line.

Sorry, my comment was very badly worded.  Please do add the line; but
don't list the dependency on ../m32r-tdep.h, since that file is not
used.

> gdb/ChangeLog:
> 
> 2005-04-13    Kei Sakamoto  <sakamoto.kei@renesas.com>
> 
>     * regformats/reg-m32r.dat: New file.
> 
> gdb/gdbserver/ChangeLog:
> 
> 2005-04-13    Kei Sakamoto  <sakamoto.kei@renesas.com>
> 
>     * Makefile.in: Add linux-m32r-low.o, reg-m32r.c and reg-m32r.o.
>     * configure.srv: Add m32r*-*-linux*.
>     * linux-m32r-low.c: New file.

This is OK, with the dependencies for linux-m32r-low.o.  Thanks a lot!

-- 
Daniel Jacobowitz
CodeSourcery, LLC


  reply	other threads:[~2005-04-14 19:18 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-04-12  5:03 Kei Sakamoto
2005-04-12 12:16 ` Daniel Jacobowitz
2005-04-13  8:01   ` Kei Sakamoto
2005-04-14 19:18     ` Daniel Jacobowitz [this message]
2005-04-15  0:30       ` Kei Sakamoto

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050414191846.GG26377@nevyn.them.org \
    --to=drow@false.org \
    --cc=gdb-patches@sources.redhat.com \
    --cc=sakamoto.kei@renesas.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox