From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19917 invoked by alias); 14 Apr 2005 19:18:50 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 19896 invoked from network); 14 Apr 2005 19:18:47 -0000 Received: from unknown (HELO nevyn.them.org) (66.93.172.17) by sourceware.org with SMTP; 14 Apr 2005 19:18:47 -0000 Received: from drow by nevyn.them.org with local (Exim 4.50 #1 (Debian)) id 1DM9rS-0004xV-Uf; Thu, 14 Apr 2005 15:18:47 -0400 Date: Thu, 14 Apr 2005 19:18:00 -0000 From: Daniel Jacobowitz To: Kei Sakamoto Cc: gdb-patches@sources.redhat.com Subject: Re: [RFC/m32r] Add gdbserver support to m32r-linux Message-ID: <20050414191846.GG26377@nevyn.them.org> Mail-Followup-To: Kei Sakamoto , gdb-patches@sources.redhat.com References: <016101c53f1d$67b40660$5169910a@E5A02646> <20050412121626.GA7373@nevyn.them.org> <013d01c53fff$6cc753e0$5169910a@E5A02646> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <013d01c53fff$6cc753e0$5169910a@E5A02646> User-Agent: Mutt/1.5.8i X-SW-Source: 2005-04/txt/msg00136.txt.bz2 On Wed, Apr 13, 2005 at 05:04:32PM +0900, Kei Sakamoto wrote: > Thank you for reviewing my patch! > I revised my patch as the following. > > > > > +linux-m32r-low.o: linux-m32r-low.c $(linux_low_h) $(server_h) ../m32r-tdep.h > > > > This doesn't seem to be necessary. > > I removed the above line. Sorry, my comment was very badly worded. Please do add the line; but don't list the dependency on ../m32r-tdep.h, since that file is not used. > gdb/ChangeLog: > > 2005-04-13 Kei Sakamoto > > * regformats/reg-m32r.dat: New file. > > gdb/gdbserver/ChangeLog: > > 2005-04-13 Kei Sakamoto > > * Makefile.in: Add linux-m32r-low.o, reg-m32r.c and reg-m32r.o. > * configure.srv: Add m32r*-*-linux*. > * linux-m32r-low.c: New file. This is OK, with the dependencies for linux-m32r-low.o. Thanks a lot! -- Daniel Jacobowitz CodeSourcery, LLC