Re: [RFA/sim] Resurrect sh64 target

[Daniel Jacobowitz <drow@false.org>]

On Wed, Mar 30, 2005 at 07:48:17PM +0200, Corinna Vinschen wrote:
> Hi,
> 
> as promised (threatened?), I'm also sending a few minor fixes to the sh64
> simulator, so that's it's possible to build an sh64 targeted GDB.
> 
> Ok to apply?
> 
> 
> Corinna
> 
> 	* configure.ac: Add explicit sh64 case.
> 	* configure: Regenerate.
> 	* sh64/configure.ac: New file.
> 	* sh64/configure.in: Remove.
> 	* sh64/configure: Regenerate.
> 	* sh64/defs-media.h (sem_fields): Add missing sfmt_ldhil member.
> 	* sh64/sim-if.c (sim_open): Use struct bfd instead of struct _bfd.
> 	(sim_create_inferior): Ditto.

Hi Corinna,

This patch is fine.  Please fix the space/tab mismatch in
sim/configure.ac before committing:

> -       sh*-*-*)
> +       sh64-*-*)
> +           AC_CONFIG_SUBDIRS(sh64)
> +	   testsuite=yes
> +	   common=yes
> +	   ;;
> +       sh-*-*)

Also, please don't send diffs to generated files to the list.  I was
putting off reviewing this because I was intimidated by the 359k file
size - which turned out to be entirely sim/sh64/configure :-)

-- 
Daniel Jacobowitz
CodeSourcery, LLC