From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22233 invoked by alias); 14 Apr 2005 17:34:34 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 22200 invoked from network); 14 Apr 2005 17:34:31 -0000 Received: from unknown (HELO nevyn.them.org) (66.93.172.17) by sourceware.org with SMTP; 14 Apr 2005 17:34:31 -0000 Received: from drow by nevyn.them.org with local (Exim 4.50 #1 (Debian)) id 1DM8EY-0006tU-Uc for ; Thu, 14 Apr 2005 13:34:31 -0400 Date: Thu, 14 Apr 2005 17:34:00 -0000 From: Daniel Jacobowitz To: gdb-patches@sources.redhat.com Subject: Re: [RFA/sim] Resurrect sh64 target Message-ID: <20050414173430.GA26377@nevyn.them.org> Mail-Followup-To: gdb-patches@sources.redhat.com References: <20050330174817.GA26190@cygbert.vinschen.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20050330174817.GA26190@cygbert.vinschen.de> User-Agent: Mutt/1.5.8i X-SW-Source: 2005-04/txt/msg00128.txt.bz2 On Wed, Mar 30, 2005 at 07:48:17PM +0200, Corinna Vinschen wrote: > Hi, > > as promised (threatened?), I'm also sending a few minor fixes to the sh64 > simulator, so that's it's possible to build an sh64 targeted GDB. > > Ok to apply? > > > Corinna > > * configure.ac: Add explicit sh64 case. > * configure: Regenerate. > * sh64/configure.ac: New file. > * sh64/configure.in: Remove. > * sh64/configure: Regenerate. > * sh64/defs-media.h (sem_fields): Add missing sfmt_ldhil member. > * sh64/sim-if.c (sim_open): Use struct bfd instead of struct _bfd. > (sim_create_inferior): Ditto. Hi Corinna, This patch is fine. Please fix the space/tab mismatch in sim/configure.ac before committing: > - sh*-*-*) > + sh64-*-*) > + AC_CONFIG_SUBDIRS(sh64) > + testsuite=yes > + common=yes > + ;; > + sh-*-*) Also, please don't send diffs to generated files to the list. I was putting off reviewing this because I was intimidated by the 359k file size - which turned out to be entirely sim/sh64/configure :-) -- Daniel Jacobowitz CodeSourcery, LLC