Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: Mark Kettenis <mark.kettenis@xs4all.nl>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [RFA] Fix problem fetching/setting FSR register (IRIX)
Date: Mon, 28 Mar 2005 22:34:00 -0000	[thread overview]
Message-ID: <20050328223416.GQ2545@adacore.com> (raw)
In-Reply-To: <200503260802.j2Q82QHU011664@elgar.sibelius.xs4all.nl>

>    2005-03-25  Joel Brobecker  <brobecker@adacore.com>
> 
> 	   * irix5-nat.c (supply_fpregset): Fix bug that caused the FSR
> 	   register value to be incorrectly written in the regcache.
> 	   (fill_fpregset): Fix bug that caused the FSR register value
> 	   to be incorrectly read from the regcache.
> 	   Fixes [E223-028].
> 
>    Tested on mips-irix. No regression. OK to apply?
> 
> Oh, my message was sort of intended as approval.  But now that you
> asked again, there's one little nit: what's that funny E223-028.  If
> it is what I think it is, then I'm not sure if we should add bug ID's
> from a non-public bug database to our ChangeLog.

Oops. Thanks for catching this. It was a copy/paste error on my part.
I made sure I didn't included it in the ChangeLog.

>    (I will submit a testcase for this asap)
> 
> A somewhat general MIPS floating-point test would be great ;-).

Hmmm, the problem is that I am not very good with floats...
I'll see what I can do.

Thanks,
-- 
Joel


      reply	other threads:[~2005-03-28 22:34 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-03-26  0:43 Joel Brobecker
2005-03-26  8:02 ` Mark Kettenis
2005-03-28 22:34   ` Joel Brobecker [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050328223416.GQ2545@adacore.com \
    --to=brobecker@adacore.com \
    --cc=gdb-patches@sources.redhat.com \
    --cc=mark.kettenis@xs4all.nl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox