Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <drow@false.org>
To: gdb-patches@sources.redhat.com
Subject: Re: [mi] organize possible exec async mi oc command reasons
Date: Thu, 24 Mar 2005 16:06:00 -0000	[thread overview]
Message-ID: <20050324160653.GB29185@nevyn.them.org> (raw)
In-Reply-To: <20050324154602.GA10558@white>

On Thu, Mar 24, 2005 at 10:46:02AM -0500, Bob Rossi wrote:
> Hi,
> 
> I am going to attempt to organize the possible MI exec async output
> commands. The current problem is that it is not easy to understand the
> possible number of 'exec async output commands' that GDB/MI can return
> to the FE. I would like to simply this, and eventually add a testcase
> for each case. This is a start at enumerating all of the case's and
> giving the user a minimal amount of information.
> 
> The design is to have mi-common.h be the interface to the rest of 
> GDB. Also, MI developers can have a place to look at to determine all
> possible supported command types.
> 
> Eli, if you can think of a better way for me to add to the doco, let me
> know.
> 
> BTW, someone please tell me if the testsuite diff is OK, for some reason
> there are minor differences between a fresh checkout and my patched
> tree, although, I think it has nothing to do with my changes.
> 
> I've attached the added files and the testsuite diff. The patch is
> below.

I don't have much comment about the patch; it seems like a plausible
idea.  However, please pay attention to the coding and formatting
standards:

- ChangeLog entries are capitalized and end with periods.
- Function definitions have the function name in the first column.
- Function braces are in the first column.
- There's a space before function argument lists.
- Function argument lists have to be indented normally; an argument
  on a new line goes at the same depth as the first argument on the
  previous line.
- Comments don't use multiple leading *s.

and so forth.

I sometimes consider myself the pedantic guardian of GDB's source code
formatting :-)

-- 
Daniel Jacobowitz
CodeSourcery, LLC


  parent reply	other threads:[~2005-03-24 16:06 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-03-24 15:46 Bob Rossi
2005-03-24 15:54 ` Daniel Jacobowitz
2005-03-24 16:06 ` Daniel Jacobowitz [this message]
2005-03-24 18:47   ` Stan Shebs
2005-03-24 21:20   ` Bob Rossi
2005-03-26 10:43     ` Eli Zaretskii
2005-04-30 19:32     ` Daniel Jacobowitz
2005-05-18  3:29       ` Bob Rossi
2005-05-18  3:34         ` Daniel Jacobowitz
2005-05-18  3:36           ` Bob Rossi
2005-05-18  3:43             ` Daniel Jacobowitz
2005-05-18  4:00               ` Bob Rossi
2005-05-18  8:53       ` Bob Rossi
2005-05-26  2:35         ` Bob Rossi
2005-05-28 18:56         ` Daniel Jacobowitz
2005-05-29  2:55           ` Bob Rossi
2005-05-29  3:00             ` Bob Rossi
2005-05-29  4:57               ` Daniel Jacobowitz
2005-05-29  5:53                 ` Bob Rossi
2005-05-29  3:11             ` Daniel Jacobowitz
2005-06-15 19:25     ` David Lecomber
2005-06-15 20:03       ` Bob Rossi
2005-06-15 20:46         ` Daniel Jacobowitz
2005-03-24 20:00 ` Eli Zaretskii
2005-03-24 21:02   ` Bob Rossi
2005-03-26 10:40     ` Eli Zaretskii
2005-03-26 13:32       ` Eli Zaretskii
2005-03-27  2:56         ` Bob Rossi
2005-03-27  4:42           ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050324160653.GB29185@nevyn.them.org \
    --to=drow@false.org \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox