From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24785 invoked by alias); 24 Mar 2005 16:06:35 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 24575 invoked from network); 24 Mar 2005 16:06:26 -0000 Received: from unknown (HELO nevyn.them.org) (66.93.172.17) by sourceware.org with SMTP; 24 Mar 2005 16:06:26 -0000 Received: from drow by nevyn.them.org with local (Exim 4.50 #1 (Debian)) id 1DEUrF-0007sS-BD for ; Thu, 24 Mar 2005 11:06:53 -0500 Date: Thu, 24 Mar 2005 16:06:00 -0000 From: Daniel Jacobowitz To: gdb-patches@sources.redhat.com Subject: Re: [mi] organize possible exec async mi oc command reasons Message-ID: <20050324160653.GB29185@nevyn.them.org> Mail-Followup-To: gdb-patches@sources.redhat.com References: <20050324154602.GA10558@white> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20050324154602.GA10558@white> User-Agent: Mutt/1.5.6+20040907i X-SW-Source: 2005-03/txt/msg00300.txt.bz2 On Thu, Mar 24, 2005 at 10:46:02AM -0500, Bob Rossi wrote: > Hi, > > I am going to attempt to organize the possible MI exec async output > commands. The current problem is that it is not easy to understand the > possible number of 'exec async output commands' that GDB/MI can return > to the FE. I would like to simply this, and eventually add a testcase > for each case. This is a start at enumerating all of the case's and > giving the user a minimal amount of information. > > The design is to have mi-common.h be the interface to the rest of > GDB. Also, MI developers can have a place to look at to determine all > possible supported command types. > > Eli, if you can think of a better way for me to add to the doco, let me > know. > > BTW, someone please tell me if the testsuite diff is OK, for some reason > there are minor differences between a fresh checkout and my patched > tree, although, I think it has nothing to do with my changes. > > I've attached the added files and the testsuite diff. The patch is > below. I don't have much comment about the patch; it seems like a plausible idea. However, please pay attention to the coding and formatting standards: - ChangeLog entries are capitalized and end with periods. - Function definitions have the function name in the first column. - Function braces are in the first column. - There's a space before function argument lists. - Function argument lists have to be indented normally; an argument on a new line goes at the same depth as the first argument on the previous line. - Comments don't use multiple leading *s. and so forth. I sometimes consider myself the pedantic guardian of GDB's source code formatting :-) -- Daniel Jacobowitz CodeSourcery, LLC