[committed] Don't clear active win32 threads

[committed] Don't clear active win32 threads

[Christopher Faylor]

I just committed this.  Hopefully, it will fix a long-standing stupid thinko.

cgf

2005-03-21  Christopher Faylor  <cgf@timesys.com>

        * win32-nat.c (do_initial_child_stuff): Don't clear the thread list
        here.
        (do_initial_child_stuff): Move clearing of thread list to a place
        before a thread ould be created.
        (child_attach): Ditto.

Index: win32-nat.c
===================================================================
RCS file: /cvs/src/src/gdb/win32-nat.c,v
retrieving revision 1.101
diff -u -p -r1.101 win32-nat.c
--- win32-nat.c	8 Oct 2004 20:29:56 -0000	1.101
+++ win32-nat.c	21 Mar 2005 19:51:01 -0000
@@ -1440,7 +1441,6 @@ do_initial_child_stuff (DWORD pid)
   current_event.dwProcessId = pid;
   memset (&current_event, 0, sizeof (current_event));
   push_target (&deprecated_child_ops);
-  child_init_thread_list ();
   disable_breakpoints_in_shlibs (1);
   child_clear_solibs ();
   clear_proceed_status ();
@@ -1586,6 +1586,7 @@ child_attach (char *args, int from_tty)
 
   pid = strtoul (args, 0, 0);		/* Windows pid */
 
+  child_init_thread_list ();
   ok = DebugActiveProcess (pid);
   saw_create = 0;
 
@@ -1858,6 +1859,7 @@ child_create_inferior (char *exec_file, 
 	}
     }
 
+  child_init_thread_list ();
   ret = CreateProcess (0,
 		       args,	/* command line */
 		       NULL,	/* Security */

Re: [committed] Don't clear active win32 threads

[Daniel Jacobowitz]

On Mon, Mar 21, 2005 at 02:55:14PM -0500, Christopher Faylor wrote:
> I just committed this.  Hopefully, it will fix a long-standing stupid thinko.
> 
> cgf
> 
> 2005-03-21  Christopher Faylor  <cgf@timesys.com>
> 
>         * win32-nat.c (do_initial_child_stuff): Don't clear the thread list
>         here.
>         (do_initial_child_stuff): Move clearing of thread list to a place
>         before a thread ould be created.
>         (child_attach): Ditto.

Great.  Does this obsolete Jerome's patch from last week?

2005-03-18  Jerome Guitton  <guitton@gnat.com>

        * win32-nat.c (child_kill_inferior): Clear the thread list.


-- 
Daniel Jacobowitz
CodeSourcery, LLC

Re: [committed] Don't clear active win32 threads

[Christopher Faylor]

On Mon, Mar 21, 2005 at 02:58:08PM -0500, Daniel Jacobowitz wrote:
>On Mon, Mar 21, 2005 at 02:55:14PM -0500, Christopher Faylor wrote:
>> I just committed this.  Hopefully, it will fix a long-standing stupid thinko.
>> 
>> cgf
>> 
>> 2005-03-21  Christopher Faylor  <cgf@timesys.com>
>> 
>>         * win32-nat.c (do_initial_child_stuff): Don't clear the thread list
>>         here.
>>         (do_initial_child_stuff): Move clearing of thread list to a place
>>         before a thread ould be created.
>>         (child_attach): Ditto.
>
>Great.  Does this obsolete Jerome's patch from last week?
>
>2005-03-18  Jerome Guitton  <guitton@gnat.com>
>
>        * win32-nat.c (child_kill_inferior): Clear the thread list.

Yes.

cgf

Re: [committed] Don't clear active win32 threads

[Jerome Guitton]

Christopher Faylor (me@cgf.cx):

> > Does this obsolete Jerome's patch from last week?
> 
> Yes.

Great! Thanks.

-- 
Jerome