Re: RFC: First stab at breakpoints in multiple locations

[Daniel Jacobowitz <drow@false.org>]

On Mon, Mar 21, 2005 at 07:50:37AM +0200, Eli Zaretskii wrote:
> > Date: Sun, 13 Mar 2005 19:38:24 -0500
> > From: Daniel Jacobowitz <drow@false.org>
> > 
> > This patch (which, obviously, I'm not proposing to commit) is an initial
> > prototype of the one breakpoint, many locations idea I've discussed before.
> 
> Thanks (and sorry for the long response time).
> 
> These changes, and the general method you propose to resolve these
> issues, are fine with me, but could you please explain the reason to
> also change seemingly unrelated places like symtab.c and linespec.c?

Sure.  Half the linespec.c changes are unnecessary; they are left over
from an earlier prototype.  That's the build_one_canonical_line_spec
change.  The other changes to linespec.c and symtab.c provide an
interface to transform "file foo.c, line 12" into "file foo.c, line 12,
PC 0x8300; file foo.c, line 12, PC 0x9300" - i.e. resolving the line to
all of its PCs instead of just one.

You've successfully picked out the rawest part of the patch :-)  I
expect all that code to be rewritten in the next version, assuming I
find the time to go back to it.

-- 
Daniel Jacobowitz
CodeSourcery, LLC