From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22139 invoked by alias); 21 Mar 2005 14:29:46 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 21628 invoked from network); 21 Mar 2005 14:29:08 -0000 Received: from unknown (HELO nevyn.them.org) (66.93.172.17) by sourceware.org with SMTP; 21 Mar 2005 14:29:08 -0000 Received: from drow by nevyn.them.org with local (Exim 4.50 #1 (Debian)) id 1DDNu5-0006bT-P1; Mon, 21 Mar 2005 09:29:14 -0500 Date: Mon, 21 Mar 2005 14:29:00 -0000 From: Daniel Jacobowitz To: Eli Zaretskii Cc: gdb-patches@sources.redhat.com Subject: Re: RFC: First stab at breakpoints in multiple locations Message-ID: <20050321142913.GA25191@nevyn.them.org> Mail-Followup-To: Eli Zaretskii , gdb-patches@sources.redhat.com References: <20050314003824.GA16626@nevyn.them.org> <01c52dda$Blat.v2.4$0d3c4020@zahav.net.il> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <01c52dda$Blat.v2.4$0d3c4020@zahav.net.il> User-Agent: Mutt/1.5.6+20040907i X-SW-Source: 2005-03/txt/msg00266.txt.bz2 On Mon, Mar 21, 2005 at 07:50:37AM +0200, Eli Zaretskii wrote: > > Date: Sun, 13 Mar 2005 19:38:24 -0500 > > From: Daniel Jacobowitz > > > > This patch (which, obviously, I'm not proposing to commit) is an initial > > prototype of the one breakpoint, many locations idea I've discussed before. > > Thanks (and sorry for the long response time). > > These changes, and the general method you propose to resolve these > issues, are fine with me, but could you please explain the reason to > also change seemingly unrelated places like symtab.c and linespec.c? Sure. Half the linespec.c changes are unnecessary; they are left over from an earlier prototype. That's the build_one_canonical_line_spec change. The other changes to linespec.c and symtab.c provide an interface to transform "file foo.c, line 12" into "file foo.c, line 12, PC 0x8300; file foo.c, line 12, PC 0x9300" - i.e. resolving the line to all of its PCs instead of just one. You've successfully picked out the rawest part of the patch :-) I expect all that code to be rewritten in the next version, assuming I find the time to go back to it. -- Daniel Jacobowitz CodeSourcery, LLC