Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <drow@false.org>
To: Joel Brobecker <brobecker@adacore.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [RFA/testsuite/dwarf2] testcase for duplicated psymtab
Date: Mon, 07 Mar 2005 19:43:00 -0000	[thread overview]
Message-ID: <20050307194251.GA18170@nevyn.them.org> (raw)
In-Reply-To: <20050203145813.GL1147@adacore.com>

On Thu, Feb 03, 2005 at 06:58:14PM +0400, Joel Brobecker wrote:
> OK to apply?

Sorry, missed this.  The gdb.dwarf2 test is OK, except your expect fu
is a little off:

> set test "info sources should contain only one reference to file1.txt"
> gdb_test_multiple "info sources" "$test" {
>   -re "file1\\.txt.*file1\\.txt.*" {
>       fail "$test (file1.txt seen more than once)"
>   }
>   -re "file1\\.txt.*" {
>       pass "$test"
>   }
>   default {
>       fail "$test (file1.txt missing from list of sources)"
>   }
> }

You should never end a regular expression with .*; it means that the
next match can get out of sync with the command stream.  Anchor them
with $gdb_prompt $.

And you don't need a "default" with gdb_test_multiple, either.

OK with those changes.

-- 
Daniel Jacobowitz
CodeSourcery, LLC


  parent reply	other threads:[~2005-03-07 19:43 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20050203145813.GL1147@adacore.com>
2005-03-07 19:30 ` Joel Brobecker
2005-03-07 19:43 ` Daniel Jacobowitz [this message]
2005-03-09  6:05   ` Joel Brobecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050307194251.GA18170@nevyn.them.org \
    --to=drow@false.org \
    --cc=brobecker@adacore.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox