From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20439 invoked by alias); 7 Mar 2005 19:43:03 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 20416 invoked from network); 7 Mar 2005 19:43:00 -0000 Received: from unknown (HELO nevyn.them.org) (66.93.172.17) by sourceware.org with SMTP; 7 Mar 2005 19:43:00 -0000 Received: from drow by nevyn.them.org with local (Exim 4.44 #1 (Debian)) id 1D8O7v-0004lS-QO; Mon, 07 Mar 2005 14:42:51 -0500 Date: Mon, 07 Mar 2005 19:43:00 -0000 From: Daniel Jacobowitz To: Joel Brobecker Cc: gdb-patches@sources.redhat.com Subject: Re: [RFA/testsuite/dwarf2] testcase for duplicated psymtab Message-ID: <20050307194251.GA18170@nevyn.them.org> Mail-Followup-To: Joel Brobecker , gdb-patches@sources.redhat.com References: <20050203145813.GL1147@adacore.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20050203145813.GL1147@adacore.com> User-Agent: Mutt/1.5.6+20040907i X-SW-Source: 2005-03/txt/msg00084.txt.bz2 On Thu, Feb 03, 2005 at 06:58:14PM +0400, Joel Brobecker wrote: > OK to apply? Sorry, missed this. The gdb.dwarf2 test is OK, except your expect fu is a little off: > set test "info sources should contain only one reference to file1.txt" > gdb_test_multiple "info sources" "$test" { > -re "file1\\.txt.*file1\\.txt.*" { > fail "$test (file1.txt seen more than once)" > } > -re "file1\\.txt.*" { > pass "$test" > } > default { > fail "$test (file1.txt missing from list of sources)" > } > } You should never end a regular expression with .*; it means that the next match can get out of sync with the command stream. Anchor them with $gdb_prompt $. And you don't need a "default" with gdb_test_multiple, either. OK with those changes. -- Daniel Jacobowitz CodeSourcery, LLC