Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Paul Gilliam <pgilliam@us.ibm.com>
To: gdb-patches@sources.redhat.com
Cc: Daniel Jacobowitz <drow@false.org>
Subject: [PATCH] obvious (I think) correction to compiler.c and compiler.cc
Date: Mon, 07 Mar 2005 18:43:00 -0000	[thread overview]
Message-ID: <200503071039.16604.pgilliam@us.ibm.com> (raw)

This fixes a problem with this committed patch:

http://sources.redhat.com/ml/gdb-patches/2005-03/msg00050.htm

'compiler.c' and 'compiler.cc' where doing the right thing, but 
get_compiler_info was not evaluating the key line because it did not begin 
with 'set'.   Rather then add another case to get_compiler_info, I changed 
the the line in compiler.c and compiler.cc to be 'set need_a_set 
[regsub....]'

At first I thought this was obvious, but because it could be fixed in 
compiler.c and compiler.cc or fixed in get_compiler_info, I thought maybe it 
wasn't so obvious.  I fixed it here in compiler.c and compiler.cc because 
those are compiler dependent and get_compiler_info is more generic.

OK to commit?

-=# Paul #=-

RCS file: /cvs/src/src/gdb/testsuite/lib/compiler.c,v
retrieving revision 1.9
diff -c -3 -p -r1.9 compiler.c
*** compiler.c  4 Mar 2005 17:35:46 -0000       1.9
--- compiler.c  7 Mar 2005 18:20:38 -0000
*************** set compiler_info [join {hpacc __HP_aCC}
*** 68,72 ****
  #if defined (__xlc__)
  /* IBM'x xlc compiler. NOTE:  __xlc__ expands to a double quoted string of 
four
     numbers seperated by '.'s: currently "7.0.0.0" */
! regsub -all {\.} [join {xlc __xlc__} -] - compiler_info
  #endif
--- 68,72 ----
  #if defined (__xlc__)
  /* IBM'x xlc compiler. NOTE:  __xlc__ expands to a double quoted string of 
four
     numbers seperated by '.'s: currently "7.0.0.0" */
! set need_a_set [regsub -all {\.} [join {xlc __xlc__} -] - compiler_info]
  #endif
Index: compiler.cc
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/lib/compiler.cc,v
retrieving revision 1.11
diff -c -3 -p -r1.11 compiler.cc
*** compiler.cc 4 Mar 2005 17:35:46 -0000       1.11
--- compiler.cc 7 Mar 2005 18:20:39 -0000
*************** set compiler_info [join {hpacc __HP_aCC}
*** 56,60 ****
  #if defined (__xlc__)
  /* IBM'x xlc compiler. NOTE:  __xlc__ expands to a double quoted string of 
four
     numbers seperated by '.'s: currently "7.0.0.0" */
! regsub -all {\.} [join {xlc __xlc__} -] - compiler_info
  #endif
--- 56,60 ----
  #if defined (__xlc__)
  /* IBM'x xlc compiler. NOTE:  __xlc__ expands to a double quoted string of 
four
     numbers seperated by '.'s: currently "7.0.0.0" */
! set need_a_set [regsub -all {\.} [join {xlc __xlc__} -] - compiler_info]
  #endif


             reply	other threads:[~2005-03-07 18:43 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-03-07 18:43 Paul Gilliam [this message]
2005-03-07 18:50 ` Daniel Jacobowitz
2005-03-07 19:00   ` [COMMIT] " Paul Gilliam
2005-03-07 19:38     ` Daniel Jacobowitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200503071039.16604.pgilliam@us.ibm.com \
    --to=pgilliam@us.ibm.com \
    --cc=drow@false.org \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox