Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <drow@false.org>
To: Jerome Guitton <guitton@adacore.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [RFA/erc32 sim] build errors
Date: Thu, 03 Mar 2005 17:19:00 -0000	[thread overview]
Message-ID: <20050303171910.GA18681@nevyn.them.org> (raw)
In-Reply-To: <20050303145856.GA15842@adacore.com>

On Thu, Mar 03, 2005 at 03:58:56PM +0100, Jerome Guitton wrote:
> Ping?

OK, I suppose.  Does the sim actually work?

> Jerome Guitton (guitton@adacore.com):
> 
> > 
> > Mainly removing the uneeded duplicated symbols and fixing some compilation
> > errors generated by GCC 3.4.
> > 
> > OK to apply?
> > 
> > 2005-02-21  Jerome Guitton  <guitton@gnat.com>
> > 
> > 	* sim/erc32/float.c (set_fsr): Do not use deprecated multi-line
> > 	strings.
> > 	(clear_accex): Ditto.
> > 	* sim/erc32/interf.c: Remove the redeclaration of fprintf.
> > 	* sim/erc32/sis.c: Ditto.
> > 	* sim/erc32/exec.c: Add missing semicolon.
> > 	* sim/erc32/func.c: Remove definitions of generic_print_address,
> > 	generic_symbol_at_address, buffer_read_memory and perror_memory, as
> > 	they are already defined in opcodes/dis-buf.c.

> > Index: float.c
> > ===================================================================
> > RCS file: /cvs/src/src/sim/erc32/float.c,v
> > retrieving revision 1.1.1.1
> > diff -u -p -r1.1.1.1 float.c
> > --- float.c	16 Apr 1999 01:35:00 -0000	1.1.1.1
> > +++ float.c	21 Feb 2005 18:00:34 -0000
> > @@ -67,11 +67,11 @@ clear_accex()
> >  #ifdef sparc
> >      set_fsr((_get_fsr_raw() & ~0x3e0));
> >  #elif i386
> > -    asm("
> > -.text
> > -	fnclex
> > -
> > -    ");
> > +    asm("\n"
> > +".text\n"
> > +"	fnclex\n"
> > +"\n"
> > +"    ");
> >  #else
> >  #warning no fpu trap support for this target
> >  #endif

FYI, using .text in asm() is highly bogus - especially in recent GCC. 
But this predates your change.

-- 
Daniel Jacobowitz
CodeSourcery, LLC


  reply	other threads:[~2005-03-03 17:19 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-02-21 19:28 Jerome Guitton
2005-02-21 22:02 ` Andrew Cagney
2005-02-22  0:29   ` Jerome Guitton
2005-03-03 15:00 ` Jerome Guitton
2005-03-03 17:19   ` Daniel Jacobowitz [this message]
2005-03-03 17:53     ` Jerome Guitton
2005-03-03 17:58       ` Daniel Jacobowitz
2005-03-07 11:11         ` Jerome Guitton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050303171910.GA18681@nevyn.them.org \
    --to=drow@false.org \
    --cc=gdb-patches@sources.redhat.com \
    --cc=guitton@adacore.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox