Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Paul Gilliam <pgilliam@us.ibm.com>
To: gdb-patches@sources.redhat.com
Subject: Re: [patch] test for altivec h/w on PowerPC
Date: Wed, 02 Mar 2005 00:36:00 -0000	[thread overview]
Message-ID: <200503011632.17599.pgilliam@us.ibm.com> (raw)
In-Reply-To: <20050301232850.GA29883@nevyn.them.org>

Daniel,

Thanks a lot for your speedy review!

I didn't know Janis wrote it, she didn't say so when she showed it to me.
(Her cube is right next to mine: we are in the same group)

On Tuesday 01 March 2005 15:28, Daniel Jacobowitz wrote:
> On Tue, Mar 01, 2005 at 03:19:39PM -0800, Paul Gilliam wrote:
> > Ok to commit?
>
> Not quite.
>
> - You've missed a changelog entry.
>
Oops.  Got it this time.

> - You're running a test on the build system instead of the target
> system.
>
Ok.  

> - This code is based on Janis's check_vmx_hw_available from GCC, so you
> might want to give credit.  Incidentally, the original version runs the
> test on $target...
Ok.

I also added a line to delete the exe file after we run it.

Ok to commit?

-=# Paul Gilliam #=-


  reply	other threads:[~2005-03-02  0:36 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-03-01 23:23 Paul Gilliam
2005-03-01 23:28 ` Daniel Jacobowitz
2005-03-02  0:36   ` Paul Gilliam [this message]
2005-03-02  1:56     ` Daniel Jacobowitz
2005-03-02 18:14       ` Paul Gilliam
2005-03-02 21:50         ` Paul Gilliam
2005-03-03 17:27           ` Daniel Jacobowitz
2005-03-10  0:43             ` Paul Gilliam
2005-03-28 23:45               ` Paul Gilliam
2005-03-29 20:43               ` Daniel Jacobowitz
2005-04-30 19:47                 ` Daniel Jacobowitz
2005-05-03  0:48                   ` [commit] " Paul Gilliam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200503011632.17599.pgilliam@us.ibm.com \
    --to=pgilliam@us.ibm.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox