From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16387 invoked by alias); 2 Mar 2005 00:36:06 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 16352 invoked from network); 2 Mar 2005 00:36:01 -0000 Received: from unknown (HELO e31.co.us.ibm.com) (32.97.110.129) by sourceware.org with SMTP; 2 Mar 2005 00:36:01 -0000 Received: from westrelay01.boulder.ibm.com (westrelay01.boulder.ibm.com [9.17.195.10]) by e31.co.us.ibm.com (8.12.10/8.12.9) with ESMTP id j220a0ua501008 for ; Tue, 1 Mar 2005 19:36:00 -0500 Received: from d03av03.boulder.ibm.com (d03av03.boulder.ibm.com [9.17.195.169]) by westrelay01.boulder.ibm.com (8.12.10/NCO/VER6.6) with ESMTP id j220a0oc167578 for ; Tue, 1 Mar 2005 17:36:00 -0700 Received: from d03av03.boulder.ibm.com (loopback [127.0.0.1]) by d03av03.boulder.ibm.com (8.12.11/8.12.11) with ESMTP id j220a0ug020012 for ; Tue, 1 Mar 2005 17:36:00 -0700 Received: from dyn319633.beaverton.ibm.com (DYN319633.beaverton.ibm.com [9.47.22.123]) by d03av03.boulder.ibm.com (8.12.11/8.12.11) with ESMTP id j220Zxxr019999 for ; Tue, 1 Mar 2005 17:36:00 -0700 From: Paul Gilliam Reply-To: pgilliam@us.ibm.com To: gdb-patches@sources.redhat.com Subject: Re: [patch] test for altivec h/w on PowerPC Date: Wed, 02 Mar 2005 00:36:00 -0000 User-Agent: KMail/1.6.2 References: <200503011519.39739.pgilliam@us.ibm.com> <20050301232850.GA29883@nevyn.them.org> In-Reply-To: <20050301232850.GA29883@nevyn.them.org> MIME-Version: 1.0 Content-Disposition: inline Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <200503011632.17599.pgilliam@us.ibm.com> X-SW-Source: 2005-03/txt/msg00011.txt.bz2 Daniel, Thanks a lot for your speedy review! I didn't know Janis wrote it, she didn't say so when she showed it to me. (Her cube is right next to mine: we are in the same group) On Tuesday 01 March 2005 15:28, Daniel Jacobowitz wrote: > On Tue, Mar 01, 2005 at 03:19:39PM -0800, Paul Gilliam wrote: > > Ok to commit? > > Not quite. > > - You've missed a changelog entry. > Oops. Got it this time. > - You're running a test on the build system instead of the target > system. > Ok. > - This code is based on Janis's check_vmx_hw_available from GCC, so you > might want to give credit. Incidentally, the original version runs the > test on $target... Ok. I also added a line to delete the exe file after we run it. Ok to commit? -=# Paul Gilliam #=-