From: Daniel Jacobowitz <drow@false.org>
To: Nathan Sidwell <nathan@codesourcery.com>,
Michael Snyder <msnyder@redhat.com>
Cc: gdb-patches@sources.redhat.com, Paul Brook <paul@codesourcery.com>
Subject: Re: [PATCH] More tracepoint fixes
Date: Sun, 27 Feb 2005 02:47:00 -0000 [thread overview]
Message-ID: <20050227002747.GB19138@nevyn.them.org> (raw)
In-Reply-To: <4209DC23.4050102@codesourcery.com>
On Wed, Feb 09, 2005 at 09:47:15AM +0000, Nathan Sidwell wrote:
> This is a more complicated tracepoint fix. The variable tracing mechanism
> does not cope with COMPUTED_LOC and ARG_COMPUTED_LOC symbols, as generated
> by gcc 3.4. Expressions containing said symbols are dealt with. This
> patch rearranges 'collect_symbol' and 'add_local_symbols' to deal with
> such computed symbols. These are dumped as if they were expressions --
> hence the breakout of the expression dumping from encode_actions.
>
> built & tested on i686-pc-linux-gnu, and an unreleased remote
> architecture. ok?
> 2005-02-09 Nathan Sidwell <nathan@codesourcery.com>
>
> * tracepoint.c: #include gdb_assert.h
> (collect_symbol): Take a PC and EXP, not a symbol. Adjust. Add
> LOC_COMPUTED and LOC_COMPUTED_ARG cases.
> (add_local_symbols): Describe the symbol with an expression,
> adjust collect_symbol calls, add LOC_COMPUTED and LOC_COMPUTED_ARG
> cases.
> (encode_actions): Break out expression processing into ...
> (add_expression): ... here. New function.
It looks sane to me, but I really can't review this; Michael, could you
take a look at it?
--
Daniel Jacobowitz
CodeSourcery, LLC
next prev parent reply other threads:[~2005-02-27 0:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-02-09 11:54 Nathan Sidwell
2005-02-27 2:47 ` Daniel Jacobowitz [this message]
2005-02-28 23:02 ` Michael Snyder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050227002747.GB19138@nevyn.them.org \
--to=drow@false.org \
--cc=gdb-patches@sources.redhat.com \
--cc=msnyder@redhat.com \
--cc=nathan@codesourcery.com \
--cc=paul@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox