From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12348 invoked by alias); 27 Feb 2005 00:27:57 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 12155 invoked from network); 27 Feb 2005 00:27:49 -0000 Received: from unknown (HELO nevyn.them.org) (66.93.172.17) by sourceware.org with SMTP; 27 Feb 2005 00:27:49 -0000 Received: from drow by nevyn.them.org with local (Exim 4.44 #1 (Debian)) id 1D5CHj-00057k-PN; Sat, 26 Feb 2005 19:27:47 -0500 Date: Sun, 27 Feb 2005 02:47:00 -0000 From: Daniel Jacobowitz To: Nathan Sidwell , Michael Snyder Cc: gdb-patches@sources.redhat.com, Paul Brook Subject: Re: [PATCH] More tracepoint fixes Message-ID: <20050227002747.GB19138@nevyn.them.org> Mail-Followup-To: Nathan Sidwell , Michael Snyder , gdb-patches@sources.redhat.com, Paul Brook References: <4209DC23.4050102@codesourcery.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4209DC23.4050102@codesourcery.com> User-Agent: Mutt/1.5.6+20040907i X-SW-Source: 2005-02/txt/msg00274.txt.bz2 On Wed, Feb 09, 2005 at 09:47:15AM +0000, Nathan Sidwell wrote: > This is a more complicated tracepoint fix. The variable tracing mechanism > does not cope with COMPUTED_LOC and ARG_COMPUTED_LOC symbols, as generated > by gcc 3.4. Expressions containing said symbols are dealt with. This > patch rearranges 'collect_symbol' and 'add_local_symbols' to deal with > such computed symbols. These are dumped as if they were expressions -- > hence the breakout of the expression dumping from encode_actions. > > built & tested on i686-pc-linux-gnu, and an unreleased remote > architecture. ok? > 2005-02-09 Nathan Sidwell > > * tracepoint.c: #include gdb_assert.h > (collect_symbol): Take a PC and EXP, not a symbol. Adjust. Add > LOC_COMPUTED and LOC_COMPUTED_ARG cases. > (add_local_symbols): Describe the symbol with an expression, > adjust collect_symbol calls, add LOC_COMPUTED and LOC_COMPUTED_ARG > cases. > (encode_actions): Break out expression processing into ... > (add_expression): ... here. New function. It looks sane to me, but I really can't review this; Michael, could you take a look at it? -- Daniel Jacobowitz CodeSourcery, LLC