From: Daniel Jacobowitz <drow@false.org>
To: Joel Brobecker <brobecker@adacore.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [RFA] Re: gdb.ada tests broken
Date: Fri, 25 Feb 2005 15:58:00 -0000 [thread overview]
Message-ID: <20050224205642.GE11751@nevyn.them.org> (raw)
In-Reply-To: <20050218215522.GA1200@adacore.com>
On Fri, Feb 18, 2005 at 01:55:22PM -0800, Joel Brobecker wrote:
> > It looks like your changes to use separate subdirectories for each test
> > has broken separate-objdir testing. My test runs from this morning
> > have:
>
> Oh no, I'm sorry. I thought I had tested my changes with out-of-source
> builds. Thanks for letting me know.
>
> > Does the test script need to create the output directory?
>
> Yes, it looks like this would be the best way of fixing the problem.
> What do you think of the attached patch?
>
> 2004-02-18 Joel Brobecker <brobecker@adacore.com>
>
> * gdb.ada/fixed_points.exp: Create compilation object directory
> before running the test.
> * gdb.ada/null_record.exp: Likewise.
> * gdb.ada/packed_array.exp: Likewise.
> * gdb.ada/start.exp: Likewise.
>
> Tested on x86-linux using both approaches: one out-of-source build,
> and one in-tree build.
Looks fine to me; please apply. Thanks!
--
Daniel Jacobowitz
CodeSourcery, LLC
next prev parent reply other threads:[~2005-02-24 20:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-02-19 11:10 Daniel Jacobowitz
2005-02-19 12:36 ` [RFA] " Joel Brobecker
2005-02-25 15:58 ` Daniel Jacobowitz [this message]
2005-02-25 16:02 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050224205642.GE11751@nevyn.them.org \
--to=drow@false.org \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox