From: Daniel Jacobowitz <drow@false.org>
To: Kevin Buettner <kevinb@redhat.com>
Cc: "Levchenko, Vasily V" <vasily.v.levchenko@intel.com>,
gdb-patches@sources.redhat.com
Subject: Re: Relative and absolute paths in link_map
Date: Thu, 17 Feb 2005 23:48:00 -0000 [thread overview]
Message-ID: <20050217174326.GA18733@nevyn.them.org> (raw)
In-Reply-To: <20050217091415.1f48a6c1@ironwood.lan>
On Thu, Feb 17, 2005 at 09:14:15AM -0700, Kevin Buettner wrote:
> On Thu, 17 Feb 2005 18:20:43 +0300
> "Levchenko, Vasily V" <vasily.v.levchenko@intel.com> wrote:
>
> > This is a patch corrects comparing of the shared object names which
> > could be relative and absolute.
> > Situation:
> > To get tls-variable from shared library.
>
> Hi Vasily,
>
> Thanks for your patch!
>
> In the future, please send some sort of context diff, that is, patches
> generated either with "diff -u" or "diff -C". (I also like it when the
> "-p" switch is used.)
>
> I have read your patch and understand what it is doing, but before
> putting your change in, I'd first like to understand why it's necessary.
> Could you offer a bit more explanation about why it is needed? Do you
> happen to have a small test case?
I'd also like to see a testcase. The patch compares only the basenames
of libraries (it should use lbasename from libiberty, by the way), but
it's possible to have two DSO plugins with the same basename and
different directories loaded.
--
Daniel Jacobowitz
CodeSourcery, LLC
next prev parent reply other threads:[~2005-02-17 17:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-02-17 16:59 Levchenko, Vasily V
2005-02-17 17:13 ` Kevin Buettner
2005-02-17 23:48 ` Daniel Jacobowitz [this message]
2005-02-18 2:32 ` Kevin Buettner
2005-02-18 16:51 Levchenko, Vasily V
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050217174326.GA18733@nevyn.them.org \
--to=drow@false.org \
--cc=gdb-patches@sources.redhat.com \
--cc=kevinb@redhat.com \
--cc=vasily.v.levchenko@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox