From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15446 invoked by alias); 17 Feb 2005 17:43:45 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 15407 invoked from network); 17 Feb 2005 17:43:37 -0000 Received: from unknown (HELO nevyn.them.org) (66.93.172.17) by sourceware.org with SMTP; 17 Feb 2005 17:43:37 -0000 Received: from drow by nevyn.them.org with local (Exim 4.44 #1 (Debian)) id 1D1pgU-0004wv-Uw; Thu, 17 Feb 2005 12:43:27 -0500 Date: Thu, 17 Feb 2005 23:48:00 -0000 From: Daniel Jacobowitz To: Kevin Buettner Cc: "Levchenko, Vasily V" , gdb-patches@sources.redhat.com Subject: Re: Relative and absolute paths in link_map Message-ID: <20050217174326.GA18733@nevyn.them.org> Mail-Followup-To: Kevin Buettner , "Levchenko, Vasily V" , gdb-patches@sources.redhat.com References: <9F0F5F4271FA9140BE3E05452E3BDAFE7F3070@mssmsx403.ccr.corp.intel.com> <20050217091415.1f48a6c1@ironwood.lan> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20050217091415.1f48a6c1@ironwood.lan> User-Agent: Mutt/1.5.6+20040907i X-SW-Source: 2005-02/txt/msg00188.txt.bz2 On Thu, Feb 17, 2005 at 09:14:15AM -0700, Kevin Buettner wrote: > On Thu, 17 Feb 2005 18:20:43 +0300 > "Levchenko, Vasily V" wrote: > > > This is a patch corrects comparing of the shared object names which > > could be relative and absolute. > > Situation: > > To get tls-variable from shared library. > > Hi Vasily, > > Thanks for your patch! > > In the future, please send some sort of context diff, that is, patches > generated either with "diff -u" or "diff -C". (I also like it when the > "-p" switch is used.) > > I have read your patch and understand what it is doing, but before > putting your change in, I'd first like to understand why it's necessary. > Could you offer a bit more explanation about why it is needed? Do you > happen to have a small test case? I'd also like to see a testcase. The patch compares only the basenames of libraries (it should use lbasename from libiberty, by the way), but it's possible to have two DSO plugins with the same basename and different directories loaded. -- Daniel Jacobowitz CodeSourcery, LLC