From: Daniel Jacobowitz <drow@false.org>
To: Joel Brobecker <brobecker@adacore.com>
Cc: Manoj Iyer <manjo@austin.ibm.com>,
gdb-patches@sources.redhat.com,
Elena Zannoni <ezannoni@redhat.com>
Subject: Re: [RFC] Dont skip DW_TAG_member in load_partial_dies()
Date: Wed, 16 Feb 2005 03:24:00 -0000 [thread overview]
Message-ID: <20050216001647.GA10512@nevyn.them.org> (raw)
In-Reply-To: <20050215233503.GB11771@adacore.com>
On Tue, Feb 15, 2005 at 03:35:03PM -0800, Joel Brobecker wrote:
> > I'm copying this to Elena, since she is the maintainer of the DWARF-2
> > reader. Your patch looks right to me. In fact, I've been working on
> > running the GDB testsuite using ARM's compiler today, and I have a
> > patch that looks exactly like this in my working directory :-)
>
> We also found the same sort of problem for Ada, and ended up doing
> the same thing. We haven't had time to submit this change yet, as
> there were a few things we wanted to thing about before doing so.
>
> Just FYI: Here is the change we've made so far in gdb-6.3.
>
> if (abbrev->tag == DW_TAG_subprogram
> || abbrev->tag == DW_TAG_variable
> || abbrev->tag == DW_TAG_namespace
> + || abbrev->tag == DW_TAG_enumeration_type
> + || abbrev->tag == DW_TAG_structure_type
That's a very different problem - you're at the other interesting if in
this function. Please show me an example of debug information which
requires this - and see the comment above which talks about why most of
these checks are only for buggy compilers...
--
Daniel Jacobowitz
CodeSourcery, LLC
next prev parent reply other threads:[~2005-02-16 0:17 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-02-16 0:17 Manoj Iyer
2005-02-16 1:09 ` Daniel Jacobowitz
2005-02-16 2:18 ` Joel Brobecker
2005-02-16 3:24 ` Daniel Jacobowitz [this message]
2005-02-16 22:50 ` Joel Brobecker
2005-02-17 14:30 ` Daniel Jacobowitz
2005-02-17 17:43 ` Joel Brobecker
2005-02-17 0:38 ` Manoj Iyer
2005-02-17 14:06 ` Daniel Jacobowitz
2005-02-16 13:46 ` Manoj Iyer
2005-03-02 18:32 ` Manoj Iyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050216001647.GA10512@nevyn.them.org \
--to=drow@false.org \
--cc=brobecker@adacore.com \
--cc=ezannoni@redhat.com \
--cc=gdb-patches@sources.redhat.com \
--cc=manjo@austin.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox