From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7702 invoked by alias); 16 Feb 2005 00:17:41 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 7201 invoked from network); 16 Feb 2005 00:17:13 -0000 Received: from unknown (HELO nevyn.them.org) (66.93.172.17) by sourceware.org with SMTP; 16 Feb 2005 00:17:13 -0000 Received: from drow by nevyn.them.org with local (Exim 4.44 #1 (Debian)) id 1D1Cs3-0002k8-9C; Tue, 15 Feb 2005 19:16:47 -0500 Date: Wed, 16 Feb 2005 03:24:00 -0000 From: Daniel Jacobowitz To: Joel Brobecker Cc: Manoj Iyer , gdb-patches@sources.redhat.com, Elena Zannoni Subject: Re: [RFC] Dont skip DW_TAG_member in load_partial_dies() Message-ID: <20050216001647.GA10512@nevyn.them.org> Mail-Followup-To: Joel Brobecker , Manoj Iyer , gdb-patches@sources.redhat.com, Elena Zannoni References: <20050215232018.GB8631@nevyn.them.org> <20050215233503.GB11771@adacore.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20050215233503.GB11771@adacore.com> User-Agent: Mutt/1.5.6+20040907i X-SW-Source: 2005-02/txt/msg00158.txt.bz2 On Tue, Feb 15, 2005 at 03:35:03PM -0800, Joel Brobecker wrote: > > I'm copying this to Elena, since she is the maintainer of the DWARF-2 > > reader. Your patch looks right to me. In fact, I've been working on > > running the GDB testsuite using ARM's compiler today, and I have a > > patch that looks exactly like this in my working directory :-) > > We also found the same sort of problem for Ada, and ended up doing > the same thing. We haven't had time to submit this change yet, as > there were a few things we wanted to thing about before doing so. > > Just FYI: Here is the change we've made so far in gdb-6.3. > > if (abbrev->tag == DW_TAG_subprogram > || abbrev->tag == DW_TAG_variable > || abbrev->tag == DW_TAG_namespace > + || abbrev->tag == DW_TAG_enumeration_type > + || abbrev->tag == DW_TAG_structure_type That's a very different problem - you're at the other interesting if in this function. Please show me an example of debug information which requires this - and see the comment above which talks about why most of these checks are only for buggy compilers... -- Daniel Jacobowitz CodeSourcery, LLC