Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Hans-Peter Nilsson <hans-peter.nilsson@axis.com>
To: cagney@gnu.org
Cc: hans-peter.nilsson@axis.com, gdb-patches@sources.redhat.com
Subject: Committed: fix sim subdir make calls
Date: Sat, 29 Jan 2005 00:57:00 -0000	[thread overview]
Message-ID: <200501290057.j0T0vSpg009689@ignucius.se.axis.com> (raw)
In-Reply-To: <41FAA54E.8080100@gnu.org> (message from Andrew Cagney on Fri, 28 Jan 2005 15:49:18 -0500)

> Date: Fri, 28 Jan 2005 15:49:18 -0500
> From: Andrew Cagney <cagney@gnu.org>

> Ah, ok (thanks).  Remember that for GDB anyone can commit configure 
> changes and fixes (just ask your self "do you feel lucky" :-).

I felt lucky fixing the sim rules.  I think you blew all your
rounds on the sim/common changes. :-)

Before, a failure in any of the sim subdirs didn't stop
compilation.  I think you saw that too, yes?  Noticed when
letting the --enable-cgen-maint build the generated C files (but
somehow the rules can't really cope with non-existing generated
files, so something like 1+2*#cpu-variants rounds is needed).
When doing that, compilation just continued on, building gdb,
then running the sim test-suite (oops! have to submit & commit
that too) but failing to find the simulator.

I checked briefly that all the rules would be present in the
subdirs, which would possibly be an arguably valid reason to not
fail when the subdir make fails.

2005-01-29  Hans-Peter Nilsson  <hp@axis.com>

	* Makefile.in (all, clean mostlyclean, distclean maintainer-clean)
	(realclean, install): Fail if subdir make failed.

Index: Makefile.in
===================================================================
RCS file: /cvs/src/src/sim/Makefile.in,v
retrieving revision 1.5
diff -p -c -u -p -r1.5 Makefile.in
cvs diff: conflicting specifications of output style
--- Makefile.in	12 Jan 2005 16:23:11 -0000	1.5
+++ Makefile.in	29 Jan 2005 00:46:14 -0000
@@ -130,7 +130,7 @@ all:
 		if [ "$$dir" = "." ]; then \
 			true; \
 		elif [ -d $$dir ]; then \
-			(cd $$dir; $(MAKE) $(FLAGS_TO_PASS)); \
+			(cd $$dir; $(MAKE) $(FLAGS_TO_PASS)) || exit 1; \
 		else true; fi; \
 	done
 
@@ -140,7 +140,7 @@ clean mostlyclean:
 		if [ "$$dir" = "." ]; then \
 			true; \
 		elif [ -d $$dir ]; then \
-			(cd $$dir; $(MAKE) $(FLAGS_TO_PASS) $@); \
+			(cd $$dir; $(MAKE) $(FLAGS_TO_PASS) $@) || exit 1; \
 		else true; fi; \
 	done
 
@@ -150,7 +150,7 @@ distclean maintainer-clean realclean:
 		if [ "$$dir" = "." ]; then \
 			true; \
 		elif [ -d $$dir ]; then \
-			(cd $$dir; $(MAKE) $(FLAGS_TO_PASS) $@); \
+			(cd $$dir; $(MAKE) $(FLAGS_TO_PASS) $@) || exit 1; \
 		else true; fi; \
 	done
 	rm -f Makefile config.cache config.log config.status
@@ -161,7 +161,7 @@ install:
 		if [ "$$dir" = "." ]; then \
 			true; \
 		elif [ -d $$dir ]; then \
-			(cd $$dir; $(MAKE) $(FLAGS_TO_PASS) install); \
+			(cd $$dir; $(MAKE) $(FLAGS_TO_PASS) install) || exit 1; \
 		else true; fi; \
 	done
 

brgds, H-P


  reply	other threads:[~2005-01-29  0:57 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-12-18 14:25 [RFA:] The CRIS simulator Hans-Peter Nilsson
2005-01-10 23:43 ` Andrew Cagney
2005-01-28  4:42   ` Hans-Peter Nilsson
2005-01-28 20:49     ` Andrew Cagney
2005-01-29  0:57       ` Hans-Peter Nilsson [this message]
2005-02-02 16:20         ` Committed: fix sim subdir make calls Andrew Cagney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200501290057.j0T0vSpg009689@ignucius.se.axis.com \
    --to=hans-peter.nilsson@axis.com \
    --cc=cagney@gnu.org \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox