From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12371 invoked by alias); 29 Jan 2005 00:57:39 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 11482 invoked from network); 29 Jan 2005 00:57:32 -0000 Received: from unknown (HELO krynn.se.axis.com) (193.13.178.10) by sourceware.org with SMTP; 29 Jan 2005 00:57:32 -0000 Received: from ignucius.se.axis.com (ignucius.se.axis.com [10.83.5.18]) by krynn.se.axis.com (8.12.9/8.12.9/Debian-5local0.1) with ESMTP id j0T0vSrH021298; Sat, 29 Jan 2005 01:57:28 +0100 Received: from ignucius.se.axis.com (localhost [127.0.0.1]) by ignucius.se.axis.com (8.12.8p1/8.12.8/Debian-2woody1) with ESMTP id j0T0vSdD009693; Sat, 29 Jan 2005 01:57:28 +0100 Received: (from hp@localhost) by ignucius.se.axis.com (8.12.8p1/8.12.8/Debian-2woody1) id j0T0vSpg009689; Sat, 29 Jan 2005 01:57:28 +0100 Date: Sat, 29 Jan 2005 00:57:00 -0000 Message-Id: <200501290057.j0T0vSpg009689@ignucius.se.axis.com> From: Hans-Peter Nilsson To: cagney@gnu.org CC: hans-peter.nilsson@axis.com, gdb-patches@sources.redhat.com In-reply-to: <41FAA54E.8080100@gnu.org> (message from Andrew Cagney on Fri, 28 Jan 2005 15:49:18 -0500) Subject: Committed: fix sim subdir make calls X-SW-Source: 2005-01/txt/msg00293.txt.bz2 > Date: Fri, 28 Jan 2005 15:49:18 -0500 > From: Andrew Cagney > Ah, ok (thanks). Remember that for GDB anyone can commit configure > changes and fixes (just ask your self "do you feel lucky" :-). I felt lucky fixing the sim rules. I think you blew all your rounds on the sim/common changes. :-) Before, a failure in any of the sim subdirs didn't stop compilation. I think you saw that too, yes? Noticed when letting the --enable-cgen-maint build the generated C files (but somehow the rules can't really cope with non-existing generated files, so something like 1+2*#cpu-variants rounds is needed). When doing that, compilation just continued on, building gdb, then running the sim test-suite (oops! have to submit & commit that too) but failing to find the simulator. I checked briefly that all the rules would be present in the subdirs, which would possibly be an arguably valid reason to not fail when the subdir make fails. 2005-01-29 Hans-Peter Nilsson * Makefile.in (all, clean mostlyclean, distclean maintainer-clean) (realclean, install): Fail if subdir make failed. Index: Makefile.in =================================================================== RCS file: /cvs/src/src/sim/Makefile.in,v retrieving revision 1.5 diff -p -c -u -p -r1.5 Makefile.in cvs diff: conflicting specifications of output style --- Makefile.in 12 Jan 2005 16:23:11 -0000 1.5 +++ Makefile.in 29 Jan 2005 00:46:14 -0000 @@ -130,7 +130,7 @@ all: if [ "$$dir" = "." ]; then \ true; \ elif [ -d $$dir ]; then \ - (cd $$dir; $(MAKE) $(FLAGS_TO_PASS)); \ + (cd $$dir; $(MAKE) $(FLAGS_TO_PASS)) || exit 1; \ else true; fi; \ done @@ -140,7 +140,7 @@ clean mostlyclean: if [ "$$dir" = "." ]; then \ true; \ elif [ -d $$dir ]; then \ - (cd $$dir; $(MAKE) $(FLAGS_TO_PASS) $@); \ + (cd $$dir; $(MAKE) $(FLAGS_TO_PASS) $@) || exit 1; \ else true; fi; \ done @@ -150,7 +150,7 @@ distclean maintainer-clean realclean: if [ "$$dir" = "." ]; then \ true; \ elif [ -d $$dir ]; then \ - (cd $$dir; $(MAKE) $(FLAGS_TO_PASS) $@); \ + (cd $$dir; $(MAKE) $(FLAGS_TO_PASS) $@) || exit 1; \ else true; fi; \ done rm -f Makefile config.cache config.log config.status @@ -161,7 +161,7 @@ install: if [ "$$dir" = "." ]; then \ true; \ elif [ -d $$dir ]; then \ - (cd $$dir; $(MAKE) $(FLAGS_TO_PASS) install); \ + (cd $$dir; $(MAKE) $(FLAGS_TO_PASS) install) || exit 1; \ else true; fi; \ done brgds, H-P