From: Daniel Jacobowitz <drow@false.org>
To: Ben Elliston <bje@au1.ibm.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: eliminate warnings in printcmd.c
Date: Fri, 10 Dec 2004 07:45:00 -0000 [thread overview]
Message-ID: <20041210043055.GA28270@nevyn.them.org> (raw)
In-Reply-To: <20041210040650.GB30314@namadgi>
On Fri, Dec 10, 2004 at 03:06:50PM +1100, Ben Elliston wrote:
> This patch eliminates warnings whereby the format string is not a
> string literal and GCC cannot check it at compile-time. I don't
> expect this patch to be tremendously popular, but my hope is that it
> will stimulate some discussion on how to really fix it :-)
It wouldn't be hard to do. The flow of printf_command is fairly
simple; part of each substring could be replaced by puts, and the rest
by printf with fixed format strings using %*.*. You're welcome to
implement that ;-)
--
Daniel Jacobowitz
prev parent reply other threads:[~2004-12-10 4:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-12-10 4:31 Ben Elliston
2004-12-10 7:45 ` Daniel Jacobowitz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041210043055.GA28270@nevyn.them.org \
--to=drow@false.org \
--cc=bje@au1.ibm.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox