From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16155 invoked by alias); 10 Dec 2004 04:31:04 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 16080 invoked from network); 10 Dec 2004 04:31:00 -0000 Received: from unknown (HELO nevyn.them.org) (66.93.172.17) by sourceware.org with SMTP; 10 Dec 2004 04:31:00 -0000 Received: from drow by nevyn.them.org with local (Exim 4.34 #1 (Debian)) id 1CccQi-0007Oo-0c; Thu, 09 Dec 2004 23:30:56 -0500 Date: Fri, 10 Dec 2004 07:45:00 -0000 From: Daniel Jacobowitz To: Ben Elliston Cc: gdb-patches@sources.redhat.com Subject: Re: eliminate warnings in printcmd.c Message-ID: <20041210043055.GA28270@nevyn.them.org> Mail-Followup-To: Ben Elliston , gdb-patches@sources.redhat.com References: <20041210040650.GB30314@namadgi> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20041210040650.GB30314@namadgi> User-Agent: Mutt/1.5.5.1+cvs20040105i X-SW-Source: 2004-12/txt/msg00259.txt.bz2 On Fri, Dec 10, 2004 at 03:06:50PM +1100, Ben Elliston wrote: > This patch eliminates warnings whereby the format string is not a > string literal and GCC cannot check it at compile-time. I don't > expect this patch to be tremendously popular, but my hope is that it > will stimulate some discussion on how to really fix it :-) It wouldn't be hard to do. The flow of printf_command is fairly simple; part of each substring could be replaced by puts, and the rest by printf with fixed format strings using %*.*. You're welcome to implement that ;-) -- Daniel Jacobowitz