From: Joel Brobecker <brobecker@adacore.com>
To: Mark Kettenis <kettenis@gnu.org>
Cc: randolph@tausq.com, gdb-patches@sources.redhat.com
Subject: Re: [RFA/RFC] Improve hppa PC reading/unwinding
Date: Tue, 07 Dec 2004 11:04:00 -0000 [thread overview]
Message-ID: <20041207100749.GB2524@adacore.com> (raw)
In-Reply-To: <200412052004.iB5K4TlY001778@elgar.sibelius.xs4all.nl>
Hello Mark from Europe!
> Index: ChangeLog
> from Mark Kettenis <kettenis@gnu.org>
>
> * hppa-tdep.h (hppa_read_pc, hppa_write_pc, hppa_unwind_pc): New
> prototypes.
> * hppa-tdep.c (hppa_read_pc): Rename from hppa_target_read_pc.
> Make global. Remove HP-UX specific code.
> (hppa_write_pc): Rename from hppa_target_write_pc. Make global.
> Remove HP-UX specific code.
> (hppa_unwind_pc): Make global. Remove HP-UX specific code.
> (hppa_frame_prev_register_helper): Set "flags" register to zero
> for all unwound frames.
> (hppa_gdbarch_init): Adjust.
> * hppa-hpux-tdep.c (HPPA_HPUX_SS_INSYSCALL): New define.
> (hppa_hpux_read_pc, hppa_hpux_write_pc)
> (hppa_hpux_unwind_pc): New functions.
> (hppa_hpux_init_abi): Set read_pc, write_pc and unwind_pc.
I read the patch, and also tested it with the little example I posted
in the thread you mentioned, and found that it fixed the problem. I
also did a bit of sanity checking and it looks good. I can also test
this change against the testsuite if necessary.
(I really like the fact that the HP/UX part is moved to the hpux tdep).
--
Joel
next prev parent reply other threads:[~2004-12-07 10:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-12-05 21:34 Mark Kettenis
2004-12-07 11:04 ` Joel Brobecker [this message]
2004-12-07 18:24 ` Mark Kettenis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041207100749.GB2524@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sources.redhat.com \
--cc=kettenis@gnu.org \
--cc=randolph@tausq.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox