From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9398 invoked by alias); 7 Dec 2004 10:07:55 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 9126 invoked from network); 7 Dec 2004 10:07:50 -0000 Received: from unknown (HELO takamaka.act-europe.fr) (212.157.227.139) by sourceware.org with SMTP; 7 Dec 2004 10:07:50 -0000 Received: by takamaka.act-europe.fr (Postfix, from userid 507) id 8850047DAB; Tue, 7 Dec 2004 11:07:49 +0100 (CET) Date: Tue, 07 Dec 2004 11:04:00 -0000 From: Joel Brobecker To: Mark Kettenis Cc: randolph@tausq.com, gdb-patches@sources.redhat.com Subject: Re: [RFA/RFC] Improve hppa PC reading/unwinding Message-ID: <20041207100749.GB2524@adacore.com> References: <200412052004.iB5K4TlY001778@elgar.sibelius.xs4all.nl> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200412052004.iB5K4TlY001778@elgar.sibelius.xs4all.nl> User-Agent: Mutt/1.4i X-SW-Source: 2004-12/txt/msg00198.txt.bz2 Hello Mark from Europe! > Index: ChangeLog > from Mark Kettenis > > * hppa-tdep.h (hppa_read_pc, hppa_write_pc, hppa_unwind_pc): New > prototypes. > * hppa-tdep.c (hppa_read_pc): Rename from hppa_target_read_pc. > Make global. Remove HP-UX specific code. > (hppa_write_pc): Rename from hppa_target_write_pc. Make global. > Remove HP-UX specific code. > (hppa_unwind_pc): Make global. Remove HP-UX specific code. > (hppa_frame_prev_register_helper): Set "flags" register to zero > for all unwound frames. > (hppa_gdbarch_init): Adjust. > * hppa-hpux-tdep.c (HPPA_HPUX_SS_INSYSCALL): New define. > (hppa_hpux_read_pc, hppa_hpux_write_pc) > (hppa_hpux_unwind_pc): New functions. > (hppa_hpux_init_abi): Set read_pc, write_pc and unwind_pc. I read the patch, and also tested it with the little example I posted in the thread you mentioned, and found that it fixed the problem. I also did a bit of sanity checking and it looks good. I can also test this change against the testsuite if necessary. (I really like the fact that the HP/UX part is moved to the hpux tdep). -- Joel