Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <drow@false.org>
To: Randolph Chung <randolph@tausq.org>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [RFC/hppa] Change handling of stubs in the return path
Date: Mon, 06 Dec 2004 23:42:00 -0000	[thread overview]
Message-ID: <20041206233728.GA32454@nevyn.them.org> (raw)
In-Reply-To: <20041206232723.GS6359@tausq.org>

On Mon, Dec 06, 2004 at 03:27:23PM -0800, Randolph Chung wrote:
> > Does this work OK when single stepping out of something, i.e. back into
> > a stub?
> 
> when you step out of a function that was called with a stub, you end up 
> back at the caller, not the stub. is that what you mean? (when we step
> into the stub, gdb detects that it is in a solib return trampoline and
> runs the inferior until it is out of the trampoline). that part is not
> really affected by this patch though.

When you step one instruction out of the function, you go from "frame
A, called by frame B" to "frame C, called by frame B".  Does GDB get
confused by this?  Try using "step"; it may decide that frame C was
called by frame A, and resume.

I guess that doesn't matter.  What usually happens in this case is GDB
loses control; but if it does, it will just hit the dummy frame
breakpoint, so who cares?

> 
> > > +static void
> > > +hppa_hpux_unwind_adjust_stub(struct frame_info *next_frame, CORE_ADDR base,
> > > +			     struct trad_frame_saved_reg *saved_regs)
> > 
> > Formatting ;-)
> 
> sorry, the original version is ok, but i did some manual editting of the
> file with vim that had expandtab set...

I meant the missing space after _stub.

-- 
Daniel Jacobowitz


  reply	other threads:[~2004-12-06 23:37 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-12-06 22:37 Randolph Chung
2004-12-06 23:27 ` Daniel Jacobowitz
2004-12-06 23:37   ` Randolph Chung
2004-12-06 23:42     ` Daniel Jacobowitz [this message]
2004-12-07  1:43       ` Randolph Chung

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20041206233728.GA32454@nevyn.them.org \
    --to=drow@false.org \
    --cc=gdb-patches@sources.redhat.com \
    --cc=randolph@tausq.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox