Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <drow@false.org>
To: Randolph Chung <randolph@tausq.org>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [RFC/hppa] Change handling of stubs in the return path
Date: Mon, 06 Dec 2004 23:27:00 -0000	[thread overview]
Message-ID: <20041206230631.GB31381@nevyn.them.org> (raw)
In-Reply-To: <20041206223712.GQ6359@tausq.org>

On Mon, Dec 06, 2004 at 02:37:12PM -0800, Randolph Chung wrote:
> The following patch changes the behavior of the unwinder for hpux so
> that export stubs are not visible when unwinding the stack. this is
> desired for several reasons as discussed on this list recently:
> 
> 1. it is less confusing to the user (and more consistent with how 
>    gdb used to work)
> 2. it improves the behavior for commands like "up" and "finish", 
>    because the user expects to return to the caller of the current
>    function, not to a stub that was synthesized by the toolchain
> 
> This fixes all the FAILs in funcargs.exp and some of the ones in
> callfuncs.exp (and possibly others, i haven't ran the whole test)
> 
> Note that the stub unwinder is still there for the cases when we single
> step into a stub.  There are some issues with the stub unwinder for HPUX
> as well, but I'll fix that separately.
> 
> comments? is this ok?

Does this work OK when single stepping out of something, i.e. back into
a stub?

> +static void
> +hppa_hpux_unwind_adjust_stub(struct frame_info *next_frame, CORE_ADDR base,
> +			     struct trad_frame_saved_reg *saved_regs)

Formatting ;-)


-- 
Daniel Jacobowitz


  reply	other threads:[~2004-12-06 23:06 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-12-06 22:37 Randolph Chung
2004-12-06 23:27 ` Daniel Jacobowitz [this message]
2004-12-06 23:37   ` Randolph Chung
2004-12-06 23:42     ` Daniel Jacobowitz
2004-12-07  1:43       ` Randolph Chung

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20041206230631.GB31381@nevyn.them.org \
    --to=drow@false.org \
    --cc=gdb-patches@sources.redhat.com \
    --cc=randolph@tausq.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox