Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: gdb-patches@sources.redhat.com
Subject: Re: [RFA/alpha] Fix problem loading core files
Date: Wed, 01 Dec 2004 17:18:00 -0000	[thread overview]
Message-ID: <20041201171752.GF1001@adacore.com> (raw)
In-Reply-To: <20041201051343.GA6267@nevyn.them.org>

> It's late, your English grammar is slipping :-)  Patch is OK with a
> couple of corrections.

Ah, if only my English was slipping only when it was late :-).

I noticed that I was also missing an entry for the changes to
alpha-nat.c. Here is the ChangeLog entry that I ended up committing:

2004-12-01  Joel Brobecker  <brobecker@gnat.com>

        * alpha-tdep.c (alpha_register_name): Add comment.
        (alpha_cannot_fetch_register): Exclude registers numbers which
        are no longer used from the list of registers that can be fetched.
        (alpha_cannot_store_register): Exclude registers numbers which
        are no longer used from the list of registers that can be stored.
        * alpha-nat.c (fetch_osf_core_registers): Add missing value in
        core_reg_mapping array.

I made the corrections you pointed out, and committed the change.

Thanks a lot for the incredibly fast review.
-- 
Joel


      reply	other threads:[~2004-12-01 17:18 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-12-01  4:31 Joel Brobecker
2004-12-01  4:57 ` Joel Brobecker
2004-12-01  5:13   ` Daniel Jacobowitz
2004-12-01 17:18     ` Joel Brobecker [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20041201171752.GF1001@adacore.com \
    --to=brobecker@adacore.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox