From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30591 invoked by alias); 1 Dec 2004 17:18:12 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 30356 invoked from network); 1 Dec 2004 17:17:57 -0000 Received: from unknown (HELO priv-edtnes84.telusplanet.net) (199.185.220.240) by sourceware.org with SMTP; 1 Dec 2004 17:17:57 -0000 Received: from takamaka.act-europe.fr ([142.179.108.108]) by priv-edtnes84.telusplanet.net (InterMail vM.6.01.03.03 201-2131-111-105-20040624) with ESMTP id <20041201171757.JZKN8584.priv-edtnes84.telusplanet.net@takamaka.act-europe.fr> for ; Wed, 1 Dec 2004 10:17:57 -0700 Received: by takamaka.act-europe.fr (Postfix, from userid 507) id BAE7447DA6; Wed, 1 Dec 2004 09:17:52 -0800 (PST) Date: Wed, 01 Dec 2004 17:18:00 -0000 From: Joel Brobecker To: gdb-patches@sources.redhat.com Subject: Re: [RFA/alpha] Fix problem loading core files Message-ID: <20041201171752.GF1001@adacore.com> References: <20041201043106.GP1204@adacore.com> <20041201045725.GQ1204@adacore.com> <20041201051343.GA6267@nevyn.them.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20041201051343.GA6267@nevyn.them.org> User-Agent: Mutt/1.4i X-SW-Source: 2004-12/txt/msg00024.txt.bz2 > It's late, your English grammar is slipping :-) Patch is OK with a > couple of corrections. Ah, if only my English was slipping only when it was late :-). I noticed that I was also missing an entry for the changes to alpha-nat.c. Here is the ChangeLog entry that I ended up committing: 2004-12-01 Joel Brobecker * alpha-tdep.c (alpha_register_name): Add comment. (alpha_cannot_fetch_register): Exclude registers numbers which are no longer used from the list of registers that can be fetched. (alpha_cannot_store_register): Exclude registers numbers which are no longer used from the list of registers that can be stored. * alpha-nat.c (fetch_osf_core_registers): Add missing value in core_reg_mapping array. I made the corrections you pointed out, and committed the change. Thanks a lot for the incredibly fast review. -- Joel