* [RFA] xstormy16-tdep.c: Initialize temporary frame cache in xstormy16_skip_prologue()
@ 2004-11-29 21:33 Kevin Buettner
0 siblings, 0 replies; 4+ messages in thread
From: Kevin Buettner @ 2004-11-29 21:33 UTC (permalink / raw)
To: gdb-patches
The patch below clears the frame cache for the call to
xstormy16_analyze_prologue(). If this initialization is not
performed, then the ``if (!cache.uses_fp)'' test following the call in
question will reference an uninitialized value.
Okay?
* xstormy16-tdep.c (xstormy16_skip_prologue): Clear/initialize the
frame cache.
Index: xstormy16-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/xstormy16-tdep.c,v
retrieving revision 1.84
diff -u -p -r1.84 xstormy16-tdep.c
--- xstormy16-tdep.c 31 Oct 2004 20:36:34 -0000 1.84
+++ xstormy16-tdep.c 29 Nov 2004 21:25:19 -0000
@@ -414,6 +414,8 @@ xstormy16_skip_prologue (CORE_ADDR pc)
struct symbol *sym;
struct xstormy16_frame_cache cache;
+ memset (&cache, 0, sizeof cache);
+
/* Don't trust line number debug info in frameless functions. */
CORE_ADDR plg_end = xstormy16_analyze_prologue (func_addr, func_end,
&cache, NULL);
^ permalink raw reply [flat|nested] 4+ messages in thread* [RFA] xstormy16-tdep.c: Initialize temporary frame cache in xstormy16_skip_prologue()
@ 2004-12-14 22:47 Kevin Buettner
2004-12-15 10:09 ` Corinna Vinschen
0 siblings, 1 reply; 4+ messages in thread
From: Kevin Buettner @ 2004-12-14 22:47 UTC (permalink / raw)
To: gdb-patches; +Cc: Corinna Vinschen
[Corinna requested that I resend this patch...]
The patch below clears the frame cache for the call to
xstormy16_analyze_prologue(). If this initialization is not
performed, then the ``if (!cache.uses_fp)'' test following the call in
question will reference an uninitialized value.
Okay?
* xstormy16-tdep.c (xstormy16_skip_prologue): Clear/initialize the
frame cache.
Index: xstormy16-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/xstormy16-tdep.c,v
retrieving revision 1.84
diff -u -p -r1.84 xstormy16-tdep.c
--- xstormy16-tdep.c 31 Oct 2004 20:36:34 -0000 1.84
+++ xstormy16-tdep.c 29 Nov 2004 21:25:19 -0000
@@ -414,6 +414,8 @@ xstormy16_skip_prologue (CORE_ADDR pc)
struct symbol *sym;
struct xstormy16_frame_cache cache;
+ memset (&cache, 0, sizeof cache);
+
/* Don't trust line number debug info in frameless functions. */
CORE_ADDR plg_end = xstormy16_analyze_prologue (func_addr, func_end,
&cache, NULL);
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [RFA] xstormy16-tdep.c: Initialize temporary frame cache in xstormy16_skip_prologue()
2004-12-14 22:47 Kevin Buettner
@ 2004-12-15 10:09 ` Corinna Vinschen
2004-12-16 15:30 ` Kevin Buettner
0 siblings, 1 reply; 4+ messages in thread
From: Corinna Vinschen @ 2004-12-15 10:09 UTC (permalink / raw)
To: gdb-patches
On Dec 14 13:00, Kevin Buettner wrote:
> [Corinna requested that I resend this patch...]
>
> The patch below clears the frame cache for the call to
> xstormy16_analyze_prologue(). If this initialization is not
> performed, then the ``if (!cache.uses_fp)'' test following the call in
> question will reference an uninitialized value.
>
> Okay?
>
> * xstormy16-tdep.c (xstormy16_skip_prologue): Clear/initialize the
> frame cache.
Sure! Please apply.
Thanks,
Corinna
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2004-12-15 22:46 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2004-11-29 21:33 [RFA] xstormy16-tdep.c: Initialize temporary frame cache in xstormy16_skip_prologue() Kevin Buettner
2004-12-14 22:47 Kevin Buettner
2004-12-15 10:09 ` Corinna Vinschen
2004-12-16 15:30 ` Kevin Buettner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox