* [RFA] unload.exp path fix
@ 2004-11-16 22:29 Randolph Chung
2004-11-16 23:57 ` Andrew Cagney
0 siblings, 1 reply; 3+ messages in thread
From: Randolph Chung @ 2004-11-16 22:29 UTC (permalink / raw)
To: gdb-patches
According to gdb.exp, gdb_get_line_number takes paths relative to
${srcdir}/${subdir}, so we should not pass in ${srcdir}/${subdir}.
without this fix, i am seeing:
ERROR: couldn't open "../../../gdb-cvs/gdb/testsuite/gdb.base/../../../gdb-cvs/gdb/testsuite/gdb.base/unloadshr.c": no such file or directory
ok?
randolph
2004-11-16 Randolph Chung <tausq@debian.org>
testsuite/
* gdb.base/unload.exp: Pass relative path to gdb_get_line_number.
Index: testsuite/gdb.base/unload.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.base/unload.exp,v
retrieving revision 1.4
diff -u -p -r1.4 unload.exp
--- testsuite/gdb.base/unload.exp 6 Sep 2004 11:09:46 -0000 1.4
+++ testsuite/gdb.base/unload.exp 16 Nov 2004 22:24:54 -0000
@@ -117,7 +117,7 @@ gdb_test "info break" \
\[0-9\]+\[\t \]+breakpoint keep y.*PENDING.*shrfunc1.*" \
"single pending breakpoint info"
-set unloadshr_line [gdb_get_line_number "unloadshr break" ${srcdir}/${subdir}/${libsrcfile}]
+set unloadshr_line [gdb_get_line_number "unloadshr break" ${libsrcfile}]
gdb_test "run" \
"Starting program.*unload.*
--
Randolph Chung
Debian GNU/Linux Developer, hppa/ia64 ports
http://www.tausq.org/
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [RFA] unload.exp path fix
2004-11-16 22:29 [RFA] unload.exp path fix Randolph Chung
@ 2004-11-16 23:57 ` Andrew Cagney
2004-11-17 0:00 ` Randolph Chung
0 siblings, 1 reply; 3+ messages in thread
From: Andrew Cagney @ 2004-11-16 23:57 UTC (permalink / raw)
To: Randolph Chung; +Cc: gdb-patches
Randolph Chung wrote:
> According to gdb.exp, gdb_get_line_number takes paths relative to
> ${srcdir}/${subdir}, so we should not pass in ${srcdir}/${subdir}.
>
> without this fix, i am seeing:
> ERROR: couldn't open "../../../gdb-cvs/gdb/testsuite/gdb.base/../../../gdb-cvs/gdb/testsuite/gdb.base/unloadshr.c": no such file or directory
Hmm, yes (but please state what it as tested on)
> -set unloadshr_line [gdb_get_line_number "unloadshr break" ${srcdir}/${subdir}/${libsrcfile}]
> +set unloadshr_line [gdb_get_line_number "unloadshr break" ${libsrcfile}]
>
> gdb_test "run" \
> "Starting program.*unload.*
Andrew
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [RFA] unload.exp path fix
2004-11-16 23:57 ` Andrew Cagney
@ 2004-11-17 0:00 ` Randolph Chung
0 siblings, 0 replies; 3+ messages in thread
From: Randolph Chung @ 2004-11-17 0:00 UTC (permalink / raw)
To: Andrew Cagney; +Cc: gdb-patches
In reference to a message from Andrew Cagney, dated Nov 16:
> Randolph Chung wrote:
> >According to gdb.exp, gdb_get_line_number takes paths relative to
> >${srcdir}/${subdir}, so we should not pass in ${srcdir}/${subdir}.
> >
> >without this fix, i am seeing:
> >ERROR: couldn't open
> >"../../../gdb-cvs/gdb/testsuite/gdb.base/../../../gdb-cvs/gdb/testsuite/gdb.base/unloadshr.c": no such file or directory
>
> Hmm, yes (but please state what it as tested on)
hppa-linux. Committed. thanks.
randolph
--
Randolph Chung
Debian GNU/Linux Developer, hppa/ia64 ports
http://www.tausq.org/
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2004-11-17 0:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2004-11-16 22:29 [RFA] unload.exp path fix Randolph Chung
2004-11-16 23:57 ` Andrew Cagney
2004-11-17 0:00 ` Randolph Chung
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox