From: Daniel Jacobowitz <drow@false.org>
To: Mark Kettenis <kettenis@gnu.org>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [RFC/RFA] Deal with intermixed 32-bit and 64-bit DWARF sections
Date: Sun, 14 Nov 2004 19:04:00 -0000 [thread overview]
Message-ID: <20041114190403.GC4138@nevyn.them.org> (raw)
In-Reply-To: <200411102128.iAALSkNM095538@elgar.sibelius.xs4all.nl>
On Wed, Nov 10, 2004 at 10:28:46PM +0100, Mark Kettenis wrote:
> Currently GDB crashes hard when we encounter both 32-bit anbd 64-bit
> DWARF sections within the same compilation unit. Keeping the mantra
> "Be liberal what you accept, but complain loudly", this patch fixes
> that.
>
> Mark
>
>
> Index: ChangeLog
> from Mark Kettenis <kettenis@gnu.org>
>
> * dwarf2read.c (dwarf2_build_psymtabs_easy): Initailize initial
> length size of compilation header to zero.
> (dwarf2_build_psymtabs_hard): Adjust info_ptr before building
> psymtabs for included files.
> (create_all_comp_units): Initailize initial length size of
> compilation header to zero.
> (read_initial_length): Complain if both 32-bit and 64-bit DWARF
> sections are encountered within the same compilation header.
> (dwarf_decode_line_header): Pass compilation header in call to
> read_initial_length.
FWIW, this looks reasonable to me.
--
Daniel Jacobowitz
prev parent reply other threads:[~2004-11-14 19:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-10 21:28 Mark Kettenis
2004-11-14 19:04 ` Daniel Jacobowitz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041114190403.GC4138@nevyn.them.org \
--to=drow@false.org \
--cc=gdb-patches@sources.redhat.com \
--cc=kettenis@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox