From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8020 invoked by alias); 14 Nov 2004 19:04:12 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 7995 invoked from network); 14 Nov 2004 19:04:08 -0000 Received: from unknown (HELO nevyn.them.org) (66.93.172.17) by sourceware.org with SMTP; 14 Nov 2004 19:04:08 -0000 Received: from drow by nevyn.them.org with local (Exim 4.34 #1 (Debian)) id 1CTPfQ-000487-6b; Sun, 14 Nov 2004 14:04:04 -0500 Date: Sun, 14 Nov 2004 19:04:00 -0000 From: Daniel Jacobowitz To: Mark Kettenis Cc: gdb-patches@sources.redhat.com Subject: Re: [RFC/RFA] Deal with intermixed 32-bit and 64-bit DWARF sections Message-ID: <20041114190403.GC4138@nevyn.them.org> Mail-Followup-To: Mark Kettenis , gdb-patches@sources.redhat.com References: <200411102128.iAALSkNM095538@elgar.sibelius.xs4all.nl> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200411102128.iAALSkNM095538@elgar.sibelius.xs4all.nl> User-Agent: Mutt/1.5.5.1+cvs20040105i X-SW-Source: 2004-11/txt/msg00309.txt.bz2 On Wed, Nov 10, 2004 at 10:28:46PM +0100, Mark Kettenis wrote: > Currently GDB crashes hard when we encounter both 32-bit anbd 64-bit > DWARF sections within the same compilation unit. Keeping the mantra > "Be liberal what you accept, but complain loudly", this patch fixes > that. > > Mark > > > Index: ChangeLog > from Mark Kettenis > > * dwarf2read.c (dwarf2_build_psymtabs_easy): Initailize initial > length size of compilation header to zero. > (dwarf2_build_psymtabs_hard): Adjust info_ptr before building > psymtabs for included files. > (create_all_comp_units): Initailize initial length size of > compilation header to zero. > (read_initial_length): Complain if both 32-bit and 64-bit DWARF > sections are encountered within the same compilation header. > (dwarf_decode_line_header): Pass compilation header in call to > read_initial_length. FWIW, this looks reasonable to me. -- Daniel Jacobowitz